From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBmHN-0007qk-In for qemu-devel@nongnu.org; Wed, 23 Dec 2015 11:28:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBmHK-0005db-CU for qemu-devel@nongnu.org; Wed, 23 Dec 2015 11:28:45 -0500 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:50720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBmHK-0005ce-3m for qemu-devel@nongnu.org; Wed, 23 Dec 2015 11:28:42 -0500 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 Dec 2015 16:28:40 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7024A17D8042 for ; Wed, 23 Dec 2015 16:29:05 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBNGSQ1P11469186 for ; Wed, 23 Dec 2015 16:28:26 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBNGSQ7W011364 for ; Wed, 23 Dec 2015 09:28:26 -0700 Date: Wed, 23 Dec 2015 17:28:23 +0100 From: Greg Kurz Message-ID: <20151223172823.3601f342@bahia.local> In-Reply-To: <20151223154626-mutt-send-email-mst@redhat.com> References: <20151217085213.10306.97858.stgit@bahia.huguette.org> <20151223154626-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cornelia Huck , qemu-devel@nongnu.org On Wed, 23 Dec 2015 15:47:00 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > > This series tries to rework cross-endian helpers for better clarity. > > It does not change behaviour, except perhaps patch 3/3 even if I could = not > > measure any performance gain. >=20 > Breaks build: >=20 > CC mips64-softmmu/hw/mips/mips_malta.o > /home/mst/scm/qemu/hw/net/vhost_net.c: In function > =E2=80=98vhost_net_set_vnet_endian=E2=80=99: > /home/mst/scm/qemu/hw/net/vhost_net.c:208:10: error: implicit > declaration of function =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > (virtio_legacy_is_cross_endian(dev) && > !virtio_is_big_endian(dev))) { > ^ > /home/mst/scm/qemu/hw/net/vhost_net.c:208:9: error: nested extern > declaration of =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 [-Werror= =3Dnested-externs] > (virtio_legacy_is_cross_endian(dev) && > !virtio_is_big_endian(dev))) { > ^ > cc1: all warnings being treated as errors > /home/mst/scm/qemu/rules.mak:57: recipe for target 'hw/net/vhost_net.o' > failed > make[1]: *** [hw/net/vhost_net.o] Error 1 > Makefile:186: recipe for target 'subdir-i386-softmmu' failed > make: *** [subdir-i386-softmmu] Error 2 >=20 >=20 > please always build all architectures. >=20 Ok. I'll do so from now on. > > --- > >=20 > > Greg Kurz (3): > > virtio: move cross-endian helper to vhost > > vhost: move virtio 1.0 check to cross-endian helper > > virtio: optimize virtio_access_is_big_endian() for little-endian = targets > >=20 > >=20 > > hw/virtio/vhost.c | 22 ++++++++++++++++++---- > > include/hw/virtio/virtio-access.h | 16 +++------------- > > 2 files changed, 21 insertions(+), 17 deletions(-) >=20