From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/7] package/nodejs: remove version choice
Date: Wed, 23 Dec 2015 18:56:53 +0100 [thread overview]
Message-ID: <20151223185653.19830dfe@free-electrons.com> (raw)
In-Reply-To: <1450872968-5834-5-git-send-email-martin@barkynet.com>
Martin,
On Wed, 23 Dec 2015 12:16:06 +0000, Martin Bark wrote:
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index eb3aeec..1aac38e 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_NODEJS
> depends on !BR2_MIPS_SOFT_FLOAT
> # ARM needs BLX, so v5t+
> depends on !BR2_ARM_CPU_ARMV4
> + depends on BR2_PACKAGE_NODEJS_0_10_X || BR2_PACKAGE_NODEJS_5_X
I don't like that the main BR2_PACKAGE_NODEJS option depends on
BR2_PACKAGE_NODEJS_0_10_X || BR2_PACKAGE_NODEJS_5_X.
Instead, please do something like:
BR2_PACKAGE_NODEJS_VERSION
string
default "5.3.0" if BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 && BR2_USE_WCHAR
default "0.10.41"
And then use BR2_PACKAGE_NODEJS_VERSION in nodejs.mk to find which
version to use.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-23 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:16 [Buildroot] [PATCH v3 1/7] package/nodejs: bump version to 5.3.0 Martin Bark
2015-12-23 12:16 ` [Buildroot] [PATCH v3 2/7] package/nodejs: removed version 0.12.9 Martin Bark
2015-12-23 12:16 ` [Buildroot] [PATCH v3 3/7] package/nodejs: correct 0.10.x option name Martin Bark
2015-12-23 12:16 ` [Buildroot] [PATCH v3 4/7] package/nodejs: fixed comment for mips soft float Martin Bark
2015-12-23 12:16 ` [Buildroot] [PATCH v3 5/7] package/nodejs: remove version choice Martin Bark
2015-12-23 17:56 ` Thomas Petazzoni [this message]
2015-12-23 18:26 ` Yann E. MORIN
2015-12-24 16:23 ` Martin Bark
2015-12-30 0:09 ` Arnout Vandecappelle
2015-12-23 12:16 ` [Buildroot] [PATCH v3 6/7] package/nodejs: fix support for uClibc-ng Martin Bark
2015-12-23 12:16 ` [Buildroot] [PATCH v3 7/7] package/libuv: " Martin Bark
2015-12-23 17:54 ` [Buildroot] [PATCH v3 1/7] package/nodejs: bump version to 5.3.0 Thomas Petazzoni
2015-12-24 16:16 ` Martin Bark
2015-12-25 17:49 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223185653.19830dfe@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.