From: Dan Carpenter <dan.carpenter@oracle.com>
To: tony@atomide.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: OMAPDSS: panel sharp-ls037v7dw01 DT support
Date: Thu, 24 Dec 2015 10:27:06 +0300 [thread overview]
Message-ID: <20151224072706.GD29642@mwanda> (raw)
Hello Tony Lindgren,
This is a semi-automatic email about new static checker warnings.
The patch be88c16a22ed: "OMAPDSS: panel sharp-ls037v7dw01 DT support"
from May 16, 2014, leads to the following Smatch complaint:
drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c:113 sharp_ls_enable()
error: we previously assumed 'ddata->vcc' could be null (see line 105)
drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
104
105 if (ddata->vcc) {
^^^^^^^^^^
Check.
106 r = regulator_enable(ddata->vcc);
107 if (r != 0)
108 return r;
109 }
110
111 r = in->ops.dpi->enable(in);
112 if (r) {
113 regulator_disable(ddata->vcc);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unchecked dereference inside function.
114 return r;
115 }
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-12-24 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 7:27 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-10 9:04 OMAPDSS: panel sharp-ls037v7dw01 DT support Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224072706.GD29642@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.