From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Zhang Rui" <rui.zhang@intel.com>, "Len Brown" <lenb@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
"Michał Kępień" <kernel@kempniu.pl>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/5] dell-wmi: Use acpi_video_handles_brightness_key_presses()
Date: Thu, 24 Dec 2015 11:04:05 +0100 [thread overview]
Message-ID: <201512241104.06427@pali> (raw)
In-Reply-To: <20151222195319.GN7244@malice.jf.intel.com>
[-- Attachment #1: Type: Text/Plain, Size: 666 bytes --]
On Tuesday 22 December 2015 20:53:19 Darren Hart wrote:
> On Tue, Dec 22, 2015 at 07:09:49PM +0100, Hans de Goede wrote:
>
> + Pali
>
> > Use the new acpi_video_handles_brightness_key_presses function to
> > check if we should report brightness key-presses.
> >
> > This makes the code both easier to read and makes it properly
> > report key-presses when acpi-video is not reporting them for
> > reasons other then the backlight type being vendor.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
After discussion I'm fine with this patch. Add my
Acked-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-12-24 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 18:09 [PATCH 0/5] acpi-video and platform/x86 driver fixes Hans de Goede
2015-12-22 18:09 ` [PATCH 1/5] acpi-video: Add a acpi_video_handles_brightness_key_presses() helper Hans de Goede
2015-12-22 18:09 ` [PATCH 2/5] dell-wmi: Use acpi_video_handles_brightness_key_presses() Hans de Goede
2015-12-22 19:53 ` Darren Hart
2015-12-24 10:04 ` Pali Rohár [this message]
2015-12-22 18:09 ` [PATCH 3/5] thinkpad_acpi: " Hans de Goede
2015-12-27 23:08 ` Henrique de Moraes Holschuh
2015-12-29 12:27 ` Hans de Goede
2015-12-30 17:28 ` Henrique de Moraes Holschuh
2015-12-22 18:09 ` [PATCH 4/5] acpi-video: Add a module option to disable the reporting of keypresses Hans de Goede
2015-12-22 20:09 ` Darren Hart
2015-12-22 18:09 ` [PATCH 5/5] acpi-video: Add quirks for the Dell Vostro V131 Hans de Goede
2015-12-22 21:00 ` [PATCH 0/5] acpi-video and platform/x86 driver fixes Darren Hart
2016-01-03 0:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512241104.06427@pali \
--to=pali.rohar@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=kernel@kempniu.pl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.