From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id f18si452677wme.1.2015.12.24.03.04.56 for ; Thu, 24 Dec 2015 03:04:56 -0800 (PST) Date: Thu, 24 Dec 2015 12:04:53 +0100 From: Alexandre Belloni To: Rob Herring Cc: Sergei Ianovich , "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" Subject: [rtc-linux] Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Message-ID: <20151224110453.GJ8623@piout.net> References: <397668667-27328-3-git-send-email-ynvich@gmail.com> <1450201525-9137-1-git-send-email-ynvich@gmail.com> <20151220033815.GD9883@rob-hp-laptop> <1450613656.15911.62.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > Well, the binding should reflect that, whether the driver needs to be > re-written is somewhat a separate question. That should probably have > been done for the DS1302 driver originally and it is not too fair for > the 2nd person to fix it. You could just have a single driver bound to > the controller node which is aware of the DS1302 being the slave > device (ignoring that part of the DT for now). > I agree with Rob here. I won't require that you fix the driver but it would be better to have a proper DT binding from the beginning so that when the driver is fixed it will still work with the previous device trees. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Date: Thu, 24 Dec 2015 12:04:53 +0100 Message-ID: <20151224110453.GJ8623@piout.net> References: <397668667-27328-3-git-send-email-ynvich@gmail.com> <1450201525-9137-1-git-send-email-ynvich@gmail.com> <20151220033815.GD9883@rob-hp-laptop> <1450613656.15911.62.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Sergei Ianovich , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" List-Id: devicetree@vger.kernel.org Hi, On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > Well, the binding should reflect that, whether the driver needs to be > re-written is somewhat a separate question. That should probably have > been done for the DS1302 driver originally and it is not too fair for > the 2nd person to fix it. You could just have a single driver bound to > the controller node which is aware of the DS1302 being the slave > device (ignoring that part of the DT for now). > I agree with Rob here. I won't require that you fix the driver but it would be better to have a proper DT binding from the beginning so that when the driver is fixed it will still work with the previous device trees. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755670AbbLXLFB (ORCPT ); Thu, 24 Dec 2015 06:05:01 -0500 Received: from down.free-electrons.com ([37.187.137.238]:36656 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754496AbbLXLE7 (ORCPT ); Thu, 24 Dec 2015 06:04:59 -0500 Date: Thu, 24 Dec 2015 12:04:53 +0100 From: Alexandre Belloni To: Rob Herring Cc: Sergei Ianovich , "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" Subject: Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Message-ID: <20151224110453.GJ8623@piout.net> References: <397668667-27328-3-git-send-email-ynvich@gmail.com> <1450201525-9137-1-git-send-email-ynvich@gmail.com> <20151220033815.GD9883@rob-hp-laptop> <1450613656.15911.62.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote : > Well, the binding should reflect that, whether the driver needs to be > re-written is somewhat a separate question. That should probably have > been done for the DS1302 driver originally and it is not too fair for > the 2nd person to fix it. You could just have a single driver bound to > the controller node which is aware of the DS1302 being the slave > device (ignoring that part of the DT for now). > I agree with Rob here. I won't require that you fix the driver but it would be better to have a proper DT binding from the beginning so that when the driver is fixed it will still work with the previous device trees. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com