All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] toolchain: granular choice for stack protector
Date: Sun, 27 Dec 2015 11:19:36 +0100	[thread overview]
Message-ID: <20151227111936.5283ba73@free-electrons.com> (raw)
In-Reply-To: <1451173326-3424-1-git-send-email-yann.morin.1998@free.fr>

Yann,

On Sun, 27 Dec 2015 00:42:06 +0100, Yann E. MORIN wrote:

> -config BR2_ENABLE_SSP
> +choice
>  	bool "build code with Stack Smashing Protection"
> -	depends on BR2_TOOLCHAIN_HAS_SSP
> +	default BR2_SSP_ALL if BR2_ENABLE_SSP # legacy
> +	default BR2_SSP_STRONG if BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

I don't understand this part. Why would we now defalut on
BR2_SSP_STRONG if gcc >= 4.9 ?

I think we should keep the default of not having SSP enabled.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-12-27 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-26 23:42 [Buildroot] [PATCHv2] toolchain: granular choice for stack protector Yann E. MORIN
2015-12-27  0:27 ` Steven Noonan
2015-12-27  9:23   ` Yann E. MORIN
2015-12-27 10:19 ` Thomas Petazzoni [this message]
2015-12-27 10:26   ` Yann E. MORIN
2015-12-27 10:44     ` Steven Noonan
2015-12-27 10:55       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151227111936.5283ba73@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.