From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: steeven lee <steeven@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] mk: fix examples build failure
Date: Mon, 28 Dec 2015 12:53:19 +0800 [thread overview]
Message-ID: <20151228045319.GC18863@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CADvXkJ4rowM8vE1BUzOWuSVU_CpZii+q5ydsLihNNo7Pgij4Tg@mail.gmail.com>
On Thu, Dec 24, 2015 at 08:38:07PM +0800, steeven lee wrote:
> 1. Fix examples build failure
Paste the build error here, so that we know you are acutally fixing a
build error. And if it's a build error specific to some GCC, or Linux
distribution, please also note it in the commit log.
> 2. make build as default output folder name
No, please do not do two things in one patch.
--yliu
>
> Signed-off-by: steeven <steeven@gmail.com>
> ---
> mk/internal/rte.extvars.mk | 4 ++--
> mk/rte.extsubdir.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
> index 040d39f..cabef0a 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
> export RTE_EXTMK
>
> # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build
> ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
> endif
>
> #
> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
> index f50f006..819020a 100644
> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
> @echo "== $@"
> $(Q)$(MAKE) -C $(@) \
> M=$(CURDIR)/$(@)/Makefile \
> - O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> + O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
> BASE_OUTPUT=$(BASE_OUTPUT) \
> CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
> S=$(CURDIR)/$(@) \
> --
> 1.9.1
next prev parent reply other threads:[~2015-12-28 4:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 12:38 [PATCH] mk: fix examples build failure steeven lee
2015-12-27 18:19 ` Thomas Monjalon
2015-12-28 4:20 ` Qiu, Michael
2016-01-05 10:20 ` steeven lee
2015-12-28 4:53 ` Yuanhan Liu [this message]
2016-02-08 15:06 ` Thomas Monjalon
2016-03-02 15:52 ` [PATCH] mk: fix error message Thomas Monjalon
2016-03-03 10:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228045319.GC18863@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=steeven@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.