From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] extensions: libxt_connmark: Add translation to nft
Date: Mon, 28 Dec 2015 13:00:28 +0100 [thread overview]
Message-ID: <20151228120028.GA14723@salvia> (raw)
In-Reply-To: <CAKHNQQGsMzYtziBfCQzdUXeNORaQys7UdCv_DPqiBoPKuvH8nw@mail.gmail.com>
On Fri, Dec 25, 2015 at 08:09:40PM +0530, Shivani Bhardwaj wrote:
> On Fri, Dec 25, 2015 at 5:43 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > The size of unsigned long depends on the architecture, so this code
> > will not work correctly.
> >
> > You have to add a connmark_mt_xlate_v0() and connmark_mt_xlate_v1(),
> > in each of these functions you have to cast data to the right
> > structure layout.
> >
> > Thanks.
>
> Thanks for explaining. I understand it now but why is this patch
> wrong? I have used connmark_xlate() and connmark_mt_xlate() in their
> respective places. Do I still get it wrong?
>
> I'm correcting this mistake for MARK.
This patch correctly handles what I indicated above, but MARK is still
wrong.
So I'm applying this patch, thanks.
next prev parent reply other threads:[~2015-12-28 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 14:33 [PATCH v3] extensions: libxt_connmark: Add translation to nft Shivani Bhardwaj
2015-12-25 12:13 ` Pablo Neira Ayuso
2015-12-25 14:39 ` Shivani Bhardwaj
2015-12-28 12:00 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-22 21:06 Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228120028.GA14723@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.