Re: [PATCH 1/2] pinctrl: intel: on enable on x86 arches and COMPILE_TEST

[Mika Westerberg <mika.westerberg@linux.intel.com>]

On Mon, Dec 28, 2015 at 12:13:32PM +0000, Peter Robinson wrote:
> On Mon, Dec 28, 2015 at 12:00 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Sun, Dec 27, 2015 at 12:22:51PM +0000, Peter Robinson wrote:
> >> If you select CONFIG_PINCTR for another unrelated architecture
> >> you need to set all the Intel pinctrl options even though they're not
> >> required. Mask them if not required.
> >>
> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> >> ---
> >>  drivers/pinctrl/intel/Kconfig | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
> >> index 4d2efad..68fa13a 100644
> >> --- a/drivers/pinctrl/intel/Kconfig
> >> +++ b/drivers/pinctrl/intel/Kconfig
> >> @@ -2,6 +2,8 @@
> >>  # Intel pin control drivers
> >>  #
> >>
> >> +if X86_GENERIC || COMPILE_TEST
> >> +
> >>  config PINCTRL_BAYTRAIL
> >>       bool "Intel Baytrail GPIO pin control"
> >>       depends on GPIOLIB && ACPI
> >
> > All of them already depend on CONFIG_ACPI so if your unrelated
> > architecture does not provide that then you should not see any of these.
> 
> ACPI is available on arm64 and there's patches around for ARM, none of
> which would support the intel hardware, hence the patch.

I see.

Then I suggest you use "if X86 || COMPILE_TEST" instead of X86_GENERIC
because the latter does not even cover 64-bit CPUs (and is more about
optimizing for generic 32-bit CPUs than selecting proper CPU
architecture).