From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] cgroup: Fix uninitialized variable warning Date: Mon, 28 Dec 2015 10:45:03 -0500 Message-ID: <20151228154503.GP5003@mtj.duckdns.org> References: <1450907607-5060-1-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KuoEu0TukXvAcjvh5mMnVQvrXsUCl0bvQWCYT+EhHSw=; b=ZokVd2SmatVQgg2DnlGjidVIIB+dUv79WGmPnzcOy8DFYsRGl5rfGAdrZD0ilfTZYA zNvd9tliztodehhNdLAt7Az879FKJmNOBeCY9lrcL9ROcF/kBGBDGWoyrsnylshkNoIj dVN0qO6KzmQmjOw/fw3afLmp/QGhCXrwR/r0CiI9r9RfDvchD6Fz2sWFy6bJVfQoMOJM oksty/6cus7s0q5mvqsMQXYMP+a/dT0PbfFIROeyfYK23fM+34cHNmQUh/68RGsd15xH 1vns+IDB8Nt1Qv5YOPmgcvP25I3l2CTXcGqCKtRrsWjYqEOHE+VaJu704DKqgoyDfza9 grVQ== Content-Disposition: inline In-Reply-To: <1450907607-5060-1-git-send-email-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8" To: Ross Zwisler Cc: Linus Torvalds , Li Zefan , Daniel Wagner , Johannes Weiner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Jones , kernel-team-b10kYP2dOMg@public.gmane.org, Aleksa Sarai , Michal Hocko , Ingo Molnar , Peter Zijlstra , Neil Horman On Wed, Dec 23, 2015 at 02:53:27PM -0700, Ross Zwisler wrote: > Commit 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migra= tion > from subtree_control enabling") introduced the following compiler war= ning: >=20 > mm/memcontrol.c: In function =E2=80=98mem_cgroup_can_attach=E2=80=99: > mm/memcontrol.c:4790:9: warning: =E2=80=98memcg=E2=80=99 may be used = uninitialized in this function [-Wmaybe-uninitialized] > mc.to =3D memcg; > ^ >=20 > Fix this by initializing 'memcg' to NULL. >=20 > This was found using gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6). >=20 > Signed-off-by: Ross Zwisler Applied to cgroup/for-4.5. Thanks. --=20 tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbbL1PpK (ORCPT ); Mon, 28 Dec 2015 10:45:10 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:36190 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbbL1PpG (ORCPT ); Mon, 28 Dec 2015 10:45:06 -0500 Date: Mon, 28 Dec 2015 10:45:03 -0500 From: Tejun Heo To: Ross Zwisler Cc: Linus Torvalds , Li Zefan , Daniel Wagner , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Jones , kernel-team@fb.com, Aleksa Sarai , Michal Hocko , Ingo Molnar , Peter Zijlstra , Neil Horman Subject: Re: [PATCH] cgroup: Fix uninitialized variable warning Message-ID: <20151228154503.GP5003@mtj.duckdns.org> References: <1450907607-5060-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450907607-5060-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2015 at 02:53:27PM -0700, Ross Zwisler wrote: > Commit 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration > from subtree_control enabling") introduced the following compiler warning: > > mm/memcontrol.c: In function ‘mem_cgroup_can_attach’: > mm/memcontrol.c:4790:9: warning: ‘memcg’ may be used uninitialized in this function [-Wmaybe-uninitialized] > mc.to = memcg; > ^ > > Fix this by initializing 'memcg' to NULL. > > This was found using gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6). > > Signed-off-by: Ross Zwisler Applied to cgroup/for-4.5. Thanks. -- tejun