From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/eigen: install .pc file
Date: Mon, 28 Dec 2015 22:13:12 +0100 [thread overview]
Message-ID: <20151228211312.GC3446@free.fr> (raw)
In-Reply-To: <20151228220540.262dfc9c@free-electrons.com>
Thomas, All,
On 2015-12-28 22:05 +0100, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
>
> On Mon, 28 Dec 2015 20:08:54 +0100, Yann E. MORIN wrote:
> > Other packages will look for eigen3.pc to detect the presence of eigen3.
> >
> > eigen3.pc is usually installed by eigen's cmake buildsystem, but we do a
> > manual install to not depend on host-cmake just to install header files.
> > But in doing so, we forgot to install the .pc file.
> >
> > Manually sed the source .pc.in to generate the final .pc file.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/eigen/eigen.mk | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> Applied, thanks.
:-)
> Since I forgot to fix it in the commit, I did a
> follow-up commit to fix the indentation. You used a mix of tabs and
> spaces in a not very consistent way.
Well, it was not really 'inconsistent' since I did it on purpose:
- the sed's -e expression were all aligned (with tabstop=8)
- the install's source and destination were aligned (with tabstop=8)
But OK, your fix provides another kind of 'consistency' ;-)
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-28 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 19:08 [Buildroot] [PATCH 0/2] jack2: add missing dependencies (branch yem/pw) Yann E. MORIN
2015-12-28 19:08 ` [Buildroot] [PATCH 1/2] package/eigen: install .pc file Yann E. MORIN
2015-12-28 21:05 ` Thomas Petazzoni
2015-12-28 21:13 ` Yann E. MORIN [this message]
2015-12-28 19:08 ` [Buildroot] [PATCH 2/2] package/jack2: add missing optional dependencies Yann E. MORIN
2015-12-28 20:42 ` Thomas Petazzoni
2015-12-28 20:49 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228211312.GC3446@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.