From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] package/gtkmm3: reorder select/depends
Date: Mon, 28 Dec 2015 22:33:36 +0100 [thread overview]
Message-ID: <20151228223336.0a9f9cdf@free-electrons.com> (raw)
In-Reply-To: <1451337814-16379-2-git-send-email-romain.naour@gmail.com>
Dear Romain Naour,
On Mon, 28 Dec 2015 22:23:33 +0100, Romain Naour wrote:
> From: Romain Naour <romain.naour@openwide.fr>
>
> From [1]:
> "Even though the ordering has absolutely no consequences in Kconfig, it
> is not logical (when reading). It is more logical and far easier to
> understand when depends come first, followed by the selects."
>
> Also, the Config.in exemple in the manual suggest to use this coding
> style [2].
>
> [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
> [2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/gtkmm3/Config.in | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-28 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 21:23 [Buildroot] [PATCH v2 1/3] package/qt: disable Qt GUI module for NiosII Romain Naour
2015-12-28 21:23 ` [Buildroot] [PATCH v2 2/3] package/gtkmm3: reorder select/depends Romain Naour
2015-12-28 21:33 ` Thomas Petazzoni [this message]
2015-12-28 21:23 ` [Buildroot] [PATCH v2 3/3] package/gtkmm3: disable for NiosII Romain Naour
2015-12-28 21:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228223336.0a9f9cdf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.