From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] core: add defconfig to .gitignore
Date: Tue, 29 Dec 2015 09:19:22 +0100 [thread overview]
Message-ID: <20151229091922.41fac4b7@free-electrons.com> (raw)
In-Reply-To: <1451249086-24341-1-git-send-email-yann.morin.1998@free.fr>
Yann,
On Sun, 27 Dec 2015 21:44:46 +0100, Yann E. MORIN wrote:
> From: Karoly Kasza <kaszak@gmail.com>
>
> After using "make safedefconfig", a defconfig file appears which is an
> extract of the .config file. When running git, it incorrectly detects it as a
> source code change.
>
> Add /defconfig to .gitignore.
>
> Signed-off-by: Karoly Kasza <kaszak@gmail.com>
> [yann.morin.1998 at free.fr: do not remove on distclean]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
I continue to question whether this is the right thing to do.
"defconfig" is really only the default name, and it can be changed to
anything by changing BR2_DEFCONFIG. So should we gitignore the default
name, but not any other name?
I'm for the principle of least surprise, and I would personally find it
odd that we gitignore the default name only. Since we can't gitignore
all defconfigs, I'd prefer to not gitignore any of them.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-29 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 20:44 [Buildroot] [PATCHv2] core: add defconfig to .gitignore Yann E. MORIN
2015-12-29 8:19 ` Thomas Petazzoni [this message]
2015-12-29 17:05 ` Yann E. MORIN
2015-12-29 17:07 ` Thomas Petazzoni
2015-12-29 17:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229091922.41fac4b7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.