Re: [PATCH v3 5/5] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

[Darren Hart <dvhart@infradead.org>]

On Wed, Dec 30, 2015 at 02:59:09AM +0100, Rafael Wysocki wrote:
> On Tuesday, December 29, 2015 04:59:10 PM Darren Hart wrote:
> > On Wed, Dec 23, 2015 at 04:14:41PM +0530, Souvik Kumar Chakravarty wrote:
> > > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry.
> > > It depends on PUNIT and PMC IPC drivers.
> > 
> > ...
> > 
> > > +config INTEL_TELEMETRY
> > > +	tristate "Intel SoC Telemetry Driver"
> > > +	default n
> > > +	depends on INTEL_PMC_IPC && INTEL_PUNIT_IPC && X86_64
> > > +	---help---
> > > +	  This driver provides interfaces to configure and use
> > > +	  telemetry for INTEL SoC from APL onwards. It is also
> > > +	  used to get various SoC events and parameters
> > > +	  directly via debugfs files. Various tools may use
> > 
> > If tools are going to be relying on it, debugfs doesn't seem like the right
> > place for it to me. Would /sys/power be more apt?
> > 
> > Rafael?
> 
> Using debugfs for things like these is not unheard of.
> 
> It all depends on whether or not the tools in question are intended to work
> on systems where debugfs is not enabled.

It was my understanding that debugfs was intended to make it clear that it may
change at any time and shouldn't be relied upon. Strictly for debug.

But, I'll defer to Rafael on this point.

-- 
Darren Hart
Intel Open Source Technology Center