From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/13] IB/srpt: chain RDMA READ/WRITE requests Date: Wed, 30 Dec 2015 10:43:32 +0100 Message-ID: <20151230094332.GC12904@lst.de> References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-9-git-send-email-hch@lst.de> <56825940.5070404@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56825940.5070404-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Christoph Hellwig , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Dec 29, 2015 at 10:58:24AM +0100, Bart Van Assche wrote: > On 12/07/2015 09:51 PM, Christoph Hellwig wrote: > > Remove struct rdma_iu and instead allocate the struct ib_rdma_wr array > > early and fill out directly. This allows us to chain the WRs, and thus > > archive both less lock contention on the HCA workqueue as well as much > > simpler error handling. > > Please consider folding the patch below into this patch. Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553AbbL3Jni (ORCPT ); Wed, 30 Dec 2015 04:43:38 -0500 Received: from verein.lst.de ([213.95.11.211]:48965 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbbL3Jne (ORCPT ); Wed, 30 Dec 2015 04:43:34 -0500 Date: Wed, 30 Dec 2015 10:43:32 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , linux-rdma@vger.kernel.org, sagig@dev.mellanox.co.il, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/13] IB/srpt: chain RDMA READ/WRITE requests Message-ID: <20151230094332.GC12904@lst.de> References: <1449521512-22921-1-git-send-email-hch@lst.de> <1449521512-22921-9-git-send-email-hch@lst.de> <56825940.5070404@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56825940.5070404@sandisk.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 29, 2015 at 10:58:24AM +0100, Bart Van Assche wrote: > On 12/07/2015 09:51 PM, Christoph Hellwig wrote: > > Remove struct rdma_iu and instead allocate the struct ib_rdma_wr array > > early and fill out directly. This allows us to chain the WRs, and thus > > archive both less lock contention on the HCA workqueue as well as much > > simpler error handling. > > Please consider folding the patch below into this patch. Looks fine, Reviewed-by: Christoph Hellwig