All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Franklin S Cooper Jr." <fcooper@ti.com>
Cc: <computersforpeace@gmail.com>, <linux-mtd@lists.infradead.org>
Subject: Re: Testing generic empty page bit flips recovery
Date: Wed, 30 Dec 2015 15:40:55 +0100	[thread overview]
Message-ID: <20151230154055.662b4df8@bbrezillon> (raw)
In-Reply-To: <5683E5CC.6020008@ti.com>

Hi Franklin,

On Wed, 30 Dec 2015 08:10:20 -0600
"Franklin S Cooper Jr." <fcooper@ti.com> wrote:

> I am trying to follow up on this discussion from this patch
> set (https://patchwork.ozlabs.org/patch/539059/) which
> suggested that Michael instead test the generic bitflips
> recovery that is implemented by Boris "mtd: nand: properly
> handle bitflips in erased pages" patchset
> (http://lists.infradead.org/pipermail/linux-mtd/2015-September/061617.html).
> I would like to test Boris patchset but first I need to
> recreate the error that his patch is fixing.
> 
> The error that the patchset is attempting to fix isn't
> something I have ever encountered before. Currently I am
> trying to reproduce this issue on a TI K2E evm that uses the
> davinci nand driver. I flashed the nand's file-system
> partition with a ubi filesystem and the board is currently
> set to boot using the file-system on the nand. After about
> 60 secs I cut the power from the board and boot the board
> again. What I would expect is that the board will eventually
> fail to mount the ubi filesystem but currently the board has
> ran for over 24 hours and powered on and off over 1400 times
> and its still mounting the file-system perfectly fine.
> 
> Any suggestions on a test case that I can use to force the
> empty page bit flips error?
> 
> 

The davinci driver seems to support raw accesses, so you can try to
apply this patch [1] against the mtd-utils tree (not sure it still
applies cleany, but it should work with mtd-utils-1.5.1), and use the
nandflipbits tool:

# flash_erase /dev/mtdX <offset> 1
# nandflipbits /dev/mtdX 1@<offset>
# nanddump -f /tmp/dump -s <offset> -l <page-size> /dev/mtdX

Without the patch, nanddump should complain about uncorrectable errors,
and if you hexdump /dev/dump you should see the bitflip.
If nanddump does not complain after applying my patch, then it means it
fixes the "bitflips in erased pages" bug.

Best Regards,

Boris

[1]http://lists.infradead.org/pipermail/linux-mtd/2014-November/056634.html
-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2015-12-30 14:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 14:10 Testing generic empty page bit flips recovery Franklin S Cooper Jr.
2015-12-30 14:40 ` Boris Brezillon [this message]
2015-12-30 15:33   ` Franklin S Cooper Jr.
2015-12-30 15:55     ` Boris Brezillon
2015-12-30 16:02     ` Boris Brezillon
2015-12-30 16:40       ` Franklin S Cooper Jr.
2015-12-30 16:52         ` Steve deRosier
2015-12-30 17:02           ` Franklin S Cooper Jr.
2015-12-30 16:59         ` Boris Brezillon
2015-12-30 17:45           ` Franklin S Cooper Jr.
2015-12-30 17:53             ` Boris Brezillon
2015-12-30 18:07               ` Franklin S Cooper Jr.
2015-12-30 19:43                 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151230154055.662b4df8@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=fcooper@ti.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.