From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 Date: Tue, 21 Jun 2016 15:18:49 +0200 Message-ID: <2015742.xhx642kbrC@diego> References: <1466483681-36110-1-git-send-email-tfiga@chromium.org> <20160621125435.GE11432@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160621125435.GE11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: David Airlie , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , dri-devel , "open list:ARM/Rockchip SoC..." , "open list:IOMMU DRIVERS" , Daniel Kurtz , Shunqian Zheng , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Mark Yao List-Id: iommu@lists.linux-foundation.org Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel: > Hi Tomasz, > > On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote: > > In simple words, DRM patches depend on IOMMU patches. > > > > More precisely: The IOMMU patches alone are supposed to not break > > anything. Same goes for the first DRM patch (7/8). Only second DRM > > patch (8/8) depends on changes introduced by its predecessors. > > The first DRM patch is 6/7, so it is 7/8 with the iommu dependency, > right? Anyway, I think the best is I take the iommu patches when Heiko > is ok with them and then the DRM tree can merge that branch in to apply > the DRM patches. > > But first Heiko should have a look at the patches. I think from all his previous work on the rockchip iommus Tomasz is a lot more qualified to judge them - which I guess he did when picking up the ones from Rockchip devs :-) . >>From a style-side, please don't carry the Reviewed-on gerrit tags over to mainline patches (patches 1 and 2). Other than that, I didn't see anything jump out and it looks all pretty nice. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 Date: Tue, 21 Jun 2016 15:18:49 +0200 Message-ID: <2015742.xhx642kbrC@diego> References: <1466483681-36110-1-git-send-email-tfiga@chromium.org> <20160621125435.GE11432@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160621125435.GE11432-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: David Airlie , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , dri-devel , "open list:ARM/Rockchip SoC..." , "open list:IOMMU DRIVERS" , Daniel Kurtz , Shunqian Zheng , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Mark Yao List-Id: linux-rockchip.vger.kernel.org Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel: > Hi Tomasz, > > On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote: > > In simple words, DRM patches depend on IOMMU patches. > > > > More precisely: The IOMMU patches alone are supposed to not break > > anything. Same goes for the first DRM patch (7/8). Only second DRM > > patch (8/8) depends on changes introduced by its predecessors. > > The first DRM patch is 6/7, so it is 7/8 with the iommu dependency, > right? Anyway, I think the best is I take the iommu patches when Heiko > is ok with them and then the DRM tree can merge that branch in to apply > the DRM patches. > > But first Heiko should have a look at the patches. I think from all his previous work on the rockchip iommus Tomasz is a lot more qualified to judge them - which I guess he did when picking up the ones from Rockchip devs :-) . >From a style-side, please don't carry the Reviewed-on gerrit tags over to mainline patches (patches 1 and 2). Other than that, I didn't see anything jump out and it looks all pretty nice. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Tue, 21 Jun 2016 15:18:49 +0200 Subject: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 In-Reply-To: <20160621125435.GE11432@8bytes.org> References: <1466483681-36110-1-git-send-email-tfiga@chromium.org> <20160621125435.GE11432@8bytes.org> Message-ID: <2015742.xhx642kbrC@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel: > Hi Tomasz, > > On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote: > > In simple words, DRM patches depend on IOMMU patches. > > > > More precisely: The IOMMU patches alone are supposed to not break > > anything. Same goes for the first DRM patch (7/8). Only second DRM > > patch (8/8) depends on changes introduced by its predecessors. > > The first DRM patch is 6/7, so it is 7/8 with the iommu dependency, > right? Anyway, I think the best is I take the iommu patches when Heiko > is ok with them and then the DRM tree can merge that branch in to apply > the DRM patches. > > But first Heiko should have a look at the patches. I think from all his previous work on the rockchip iommus Tomasz is a lot more qualified to judge them - which I guess he did when picking up the ones from Rockchip devs :-) . >>From a style-side, please don't carry the Reviewed-on gerrit tags over to mainline patches (patches 1 and 2). Other than that, I didn't see anything jump out and it looks all pretty nice. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbcFUNxE (ORCPT ); Tue, 21 Jun 2016 09:53:04 -0400 Received: from gloria.sntech.de ([95.129.55.99]:47616 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbcFUNxA (ORCPT ); Tue, 21 Jun 2016 09:53:00 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Joerg Roedel Cc: Tomasz Figa , "open list:IOMMU DRIVERS" , dri-devel , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , David Airlie , Mark Yao , Shunqian Zheng , Daniel Kurtz , Marek Szyprowski Subject: Re: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 Date: Tue, 21 Jun 2016 15:18:49 +0200 Message-ID: <2015742.xhx642kbrC@diego> User-Agent: KMail/4.14.10 (Linux/4.5.0-2-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160621125435.GE11432@8bytes.org> References: <1466483681-36110-1-git-send-email-tfiga@chromium.org> <20160621125435.GE11432@8bytes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel: > Hi Tomasz, > > On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote: > > In simple words, DRM patches depend on IOMMU patches. > > > > More precisely: The IOMMU patches alone are supposed to not break > > anything. Same goes for the first DRM patch (7/8). Only second DRM > > patch (8/8) depends on changes introduced by its predecessors. > > The first DRM patch is 6/7, so it is 7/8 with the iommu dependency, > right? Anyway, I think the best is I take the iommu patches when Heiko > is ok with them and then the DRM tree can merge that branch in to apply > the DRM patches. > > But first Heiko should have a look at the patches. I think from all his previous work on the rockchip iommus Tomasz is a lot more qualified to judge them - which I guess he did when picking up the ones from Rockchip devs :-) . >>From a style-side, please don't carry the Reviewed-on gerrit tags over to mainline patches (patches 1 and 2). Other than that, I didn't see anything jump out and it looks all pretty nice. Heiko