Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Thu, Dec 31, 2015 at 03:12:11PM +0100, Arnd Bergmann wrote:
> On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote:
> > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote:
> > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote:
> > > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote:
> > > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
> > > > This is something that would be caught by running 'make C=1' with 'sparse'
> > > > on your patch. Can you try that to see if you introduce any other warnings?
> > > OK. I do not do it before, there is no extra warning after apply the above
> > > patch.
> > > > I'm guessing it's fine, but it would be nice to confirm. I also send a lot
> > > > of patches without running sparse and checkpatch first, but it's generally
> > > > a good idea.
> > > Got you. I only do the checkpatch in past. I will do sparse and checkpatch
> > > in future.
> > 
> > Usually sparse will be part of the tests that are done by 0day.
> > Anyway, it worked perfectly in 64bit systems also. Can you please send
> > your patch v3  with this change..
> > 
> 
> Ah, cool, thanks so much for testing.

My pleasure.
Being parport maintainer I get patches very rarely. So I should not
leave a chance to test when i get one. :)
> 
> Did you happen to check with both 32-bit and 64-bit user space on a
> 64-bit kernel? This is one of the things that was not working originally
> but should work now.

I dont think I can manage 32 bit userspace on 64-bit kernel here. But I
can definitely check it on a kvm guest.

regards
sudip