All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] python-can: bump to 1.4.1
Date: Fri, 1 Jan 2016 23:49:14 +0100	[thread overview]
Message-ID: <20160101224914.GE2182@free.fr> (raw)
In-Reply-To: <20160101222835.GD2182@free.fr>

Yegor, All,

On 2016-01-01 23:28 +0100, Yann E. MORIN spake thusly:
> On 2016-01-01 23:18 +0100, Yegor Yefremov spake thusly:
> > Add hash file and change download location to PyPi.
> 
> Why did you change the location?
> 
> I think we want to use upstream locations as much as possible, and only
> fallback to alternative locations when there is no upstream, or upstream
> is flaky.

OK, I think I know why you wanted to download from PyPi: the current
package we have will download an archive named ae5b6cf.tar.gz without
the name of the package.

That's because Bitbucket provides snapshots as such.

Also, there is not 'tag' per-se in the repository; upstream only
updates the version in the setup.py script.

I don't think it is bad to use a hash when there is no human-readable
version tagged. But we are currently using the short hash, when we
require the full hash.

So, I'd suggest we fix it by using the Hg download method:

    PYTHON_CAN_VERSION = 4085cffd2519f0ce21779e26b5c43ce8c007e9aa
    PYHTON_CAN_SITE = https://bitbucket.org/hardbyte/python-can
    PYHTON_CAN_SITE_METHOD = hg

Then we have tarballs properly named with the package name and the full
hash.

Care to update and respin, please? Thanks!

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  package/python-can/python-can.hash | 3 +++
> >  package/python-can/python-can.mk   | 5 ++---
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> >  create mode 100644 package/python-can/python-can.hash
> > 
> > diff --git a/package/python-can/python-can.hash b/package/python-can/python-can.hash
> > new file mode 100644
> > index 0000000..fc9fc2a
> > --- /dev/null
> > +++ b/package/python-can/python-can.hash
> > @@ -0,0 +1,3 @@
> > +# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=63e922ae913bb0db1dd54e9189810130, sha256 locally computed
> > +md5     63e922ae913bb0db1dd54e9189810130  python-can-1.4.1.tar.gz
> > +sha256  ab60195d112504fc4d38b74fb4a6874cd509066472b9d6d3516a8ce1485cec6f  python-can-1.4.1.tar.gz
> > diff --git a/package/python-can/python-can.mk b/package/python-can/python-can.mk
> > index c7b06a5..9a9d9df 100644
> > --- a/package/python-can/python-can.mk
> > +++ b/package/python-can/python-can.mk
> > @@ -4,9 +4,8 @@
> >  #
> >  ################################################################################
> >  
> > -PYTHON_CAN_VERSION = ae5b6cf
> > -PYTHON_CAN_SITE = https://bitbucket.org/hardbyte/python-can/get
> > -PYTHON_CAN_SOURCE = $(PYTHON_CAN_VERSION).tar.bz2
> > +PYTHON_CAN_VERSION = 1.4.1
> > +PYTHON_CAN_SITE = https://pypi.python.org/packages/source/p/python-can
> >  PYTHON_CAN_LICENSE = LGPLv3
> >  PYTHON_CAN_LICENSE_FILES = LICENSE.txt
> >  PYTHON_CAN_SETUP_TYPE = setuptools
> > -- 
> > 2.1.4
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-01-01 22:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 22:18 [Buildroot] [PATCH] python-can: bump to 1.4.1 Yegor Yefremov
2016-01-01 22:28 ` Yann E. MORIN
2016-01-01 22:49   ` Yann E. MORIN [this message]
2016-01-02  9:05     ` Yegor Yefremov
2016-01-02 11:15       ` Yann E. MORIN
2016-01-02 21:04         ` Arnout Vandecappelle
2016-01-02 21:50           ` Angelo Compagnucci
2016-01-03 22:24             ` Arnout Vandecappelle
2016-01-04  8:54               ` Yegor Yefremov
2016-01-13 14:26                 ` Yegor Yefremov
2016-01-02 22:31   ` Thomas Petazzoni
2016-01-03 20:50     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160101224914.GE2182@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.