All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sudip Mukherjee <sudip@vectorindia.org>
Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
Date: Sat, 2 Jan 2016 13:17:41 +0530	[thread overview]
Message-ID: <20160102074740.GA11430@sudip-pc> (raw)
In-Reply-To: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com>

On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
> 
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
> 
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
> 
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
> 
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-serial@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sudip Mukherjee <sudip@vectorindia.org>
> Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---

I think this has not yet landed in linux-next. next-20151231 still
fails.

regards
sudip

  parent reply	other threads:[~2016-01-02  7:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 15:05 [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Paul Gortmaker
2015-12-17 15:05 ` Paul Gortmaker
2015-12-17 15:43 ` Nicolas Ferre
2015-12-17 15:43   ` Nicolas Ferre
2015-12-17 16:48 ` Sudip Mukherjee
2016-01-02  7:47 ` Sudip Mukherjee [this message]
2016-01-04 20:43   ` Paul Gortmaker
2016-01-04 20:43     ` Paul Gortmaker
2016-01-05  7:03     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160102074740.GA11430@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=sudip@vectorindia.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.