From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards
Date: Sun, 3 Jan 2016 21:44:14 +0100 [thread overview]
Message-ID: <201601032144.14138.marex@denx.de> (raw)
In-Reply-To: <56893681.7020006@denx.de>
On Sunday, January 03, 2016 at 03:56:01 PM, Stefano Babic wrote:
> Hi Michael,
>
> some aditional comments before you will send V3:
[...]
> > diff --git a/board/i2se/duckbill/Makefile b/board/i2se/duckbill/Makefile
> > new file mode 100644
> > index 0000000..b5577e3
> > --- /dev/null
> > +++ b/board/i2se/duckbill/Makefile
> > @@ -0,0 +1,12 @@
> > +#
> > +# (C) Copyright 2014-2015
> > +# Michael Heimpold, mhei at heimpold.de.
> > +#
> > +# SPDX-License-Identifier: GPL-2.0+
> > +#
> > +
> > +ifndef CONFIG_SPL_BUILD
> > +obj-y := duckbill.o
> > +else
> > +obj-y := iomux.o
> > +endif
All the MXS boards should use spl.o , since it's not only iomux in there.
> Well, it is okay if you want to maintain the name, but iomux is one of
> the most used name for files. What about duckbill-iomux ?
>
[...]
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-01-03 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 11:09 [U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards Michael Heimpold
2015-12-13 15:40 ` Marek Vasut
2015-12-13 21:53 ` Michael Heimpold
2015-12-13 22:45 ` Marek Vasut
2016-01-03 14:56 ` Stefano Babic
2016-01-03 20:44 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601032144.14138.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.