From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Mon, 04 Jan 2016 07:10:12 +0000 Subject: Re: [PATCH] drm/dp/mst: constify drm_dp_mst_topology_cbs structures Message-Id: <20160104071012.GD8076@phenom.ffwll.local> List-Id: References: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter On Wed, Dec 30, 2015 at 10:20:30PM +0100, Julia Lawall wrote: > The drm_dp_mst_topology_cbs structures are never modified, so declare them > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied to drm-misc, thanks. -Daniel > > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- > include/drm/drm_dp_mst_helper.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h > index 74b5888..b37b859 100644 > --- a/include/drm/drm_dp_mst_helper.h > +++ b/include/drm/drm_dp_mst_helper.h > @@ -421,7 +421,7 @@ struct drm_dp_payload { > struct drm_dp_mst_topology_mgr { > > struct device *dev; > - struct drm_dp_mst_topology_cbs *cbs; > + const struct drm_dp_mst_topology_cbs *cbs; > int max_dpcd_transaction_bytes; > struct drm_dp_aux *aux; /* auxch for this topology mgr to use */ > int max_payloads; > diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c > index 94323f5..8a02225 100644 > --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c > +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c > @@ -329,7 +329,7 @@ static void radeon_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -struct drm_dp_mst_topology_cbs mst_cbs = { > +const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = radeon_dp_add_mst_connector, > .register_connector = radeon_dp_register_mst_connector, > .destroy_connector = radeon_dp_destroy_mst_connector, > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > index e2f515d..fa0dabf 100644 > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > @@ -534,7 +534,7 @@ static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -static struct drm_dp_mst_topology_cbs mst_cbs = { > +static const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = intel_dp_add_mst_connector, > .register_connector = intel_dp_register_mst_connector, > .destroy_connector = intel_dp_destroy_mst_connector, > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/dp/mst: constify drm_dp_mst_topology_cbs structures Date: Mon, 4 Jan 2016 08:10:12 +0100 Message-ID: <20160104071012.GD8076@phenom.ffwll.local> References: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Julia Lawall Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgMzAsIDIwMTUgYXQgMTA6MjA6MzBQTSArMDEwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IFRoZSBkcm1fZHBfbXN0X3RvcG9sb2d5X2NicyBzdHJ1Y3R1cmVzIGFyZSBuZXZlciBt b2RpZmllZCwgc28gZGVjbGFyZSB0aGVtCj4gYXMgY29uc3QuCj4gCj4gRG9uZSB3aXRoIHRoZSBo ZWxwIG9mIENvY2NpbmVsbGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogSnVsaWEgTGF3YWxsIDxKdWxp YS5MYXdhbGxAbGlwNi5mcj4KCkFwcGxpZWQgdG8gZHJtLW1pc2MsIHRoYW5rcy4KLURhbmllbAoK PiAKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMgICAgfCAgICAy ICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2RwX21zdC5jIHwgICAgMiArLQo+ ICBpbmNsdWRlL2RybS9kcm1fZHBfbXN0X2hlbHBlci5oICAgICAgICB8ICAgIDIgKy0KPiAgMyBm aWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvZHJtL2RybV9kcF9tc3RfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1f ZHBfbXN0X2hlbHBlci5oCj4gaW5kZXggNzRiNTg4OC4uYjM3Yjg1OSAxMDA2NDQKPiAtLS0gYS9p bmNsdWRlL2RybS9kcm1fZHBfbXN0X2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Rw X21zdF9oZWxwZXIuaAo+IEBAIC00MjEsNyArNDIxLDcgQEAgc3RydWN0IGRybV9kcF9wYXlsb2Fk IHsKPiAgc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyIHsKPiAgCj4gIAlzdHJ1Y3QgZGV2 aWNlICpkZXY7Cj4gLQlzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9jYnMgKmNiczsKPiArCWNv bnN0IHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X2NicyAqY2JzOwo+ICAJaW50IG1heF9kcGNk X3RyYW5zYWN0aW9uX2J5dGVzOwo+ICAJc3RydWN0IGRybV9kcF9hdXggKmF1eDsgLyogYXV4Y2gg Zm9yIHRoaXMgdG9wb2xvZ3kgbWdyIHRvIHVzZSAqLwo+ICAJaW50IG1heF9wYXlsb2FkczsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZHBfbXN0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcF9tc3QuYwo+IGluZGV4IDk0MzIzZjUuLjhhMDIy MjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZHBfbXN0LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcF9tc3QuYwo+IEBAIC0zMjks NyArMzI5LDcgQEAgc3RhdGljIHZvaWQgcmFkZW9uX2RwX21zdF9ob3RwbHVnKHN0cnVjdCBkcm1f ZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyKQo+ICAJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVu dChkZXYpOwo+ICB9Cj4gIAo+IC1zdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9jYnMgbXN0X2Ni cyA9IHsKPiArY29uc3Qgc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfY2JzIG1zdF9jYnMgPSB7 Cj4gIAkuYWRkX2Nvbm5lY3RvciA9IHJhZGVvbl9kcF9hZGRfbXN0X2Nvbm5lY3RvciwKPiAgCS5y ZWdpc3Rlcl9jb25uZWN0b3IgPSByYWRlb25fZHBfcmVnaXN0ZXJfbXN0X2Nvbm5lY3RvciwKPiAg CS5kZXN0cm95X2Nvbm5lY3RvciA9IHJhZGVvbl9kcF9kZXN0cm95X21zdF9jb25uZWN0b3IsCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiBpbmRleCBlMmY1MTVkLi5mYTBkYWJmIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiBAQCAtNTM0LDcgKzUzNCw3IEBA IHN0YXRpYyB2b2lkIGludGVsX2RwX21zdF9ob3RwbHVnKHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9s b2d5X21nciAqbWdyKQo+ICAJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChkZXYpOwo+ICB9 Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfY2JzIG1zdF9jYnMgPSB7 Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9jYnMgbXN0X2NicyA9 IHsKPiAgCS5hZGRfY29ubmVjdG9yID0gaW50ZWxfZHBfYWRkX21zdF9jb25uZWN0b3IsCj4gIAku cmVnaXN0ZXJfY29ubmVjdG9yID0gaW50ZWxfZHBfcmVnaXN0ZXJfbXN0X2Nvbm5lY3RvciwKPiAg CS5kZXN0cm95X2Nvbm5lY3RvciA9IGludGVsX2RwX2Rlc3Ryb3lfbXN0X2Nvbm5lY3RvciwKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0g CkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6 Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbcADHKR (ORCPT ); Mon, 4 Jan 2016 02:10:17 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37665 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbcADHKP (ORCPT ); Mon, 4 Jan 2016 02:10:15 -0500 Date: Mon, 4 Jan 2016 08:10:12 +0100 From: Daniel Vetter To: Julia Lawall Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter Subject: Re: [PATCH] drm/dp/mst: constify drm_dp_mst_topology_cbs structures Message-ID: <20160104071012.GD8076@phenom.ffwll.local> Mail-Followup-To: Julia Lawall , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter References: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2015 at 10:20:30PM +0100, Julia Lawall wrote: > The drm_dp_mst_topology_cbs structures are never modified, so declare them > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied to drm-misc, thanks. -Daniel > > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- > include/drm/drm_dp_mst_helper.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h > index 74b5888..b37b859 100644 > --- a/include/drm/drm_dp_mst_helper.h > +++ b/include/drm/drm_dp_mst_helper.h > @@ -421,7 +421,7 @@ struct drm_dp_payload { > struct drm_dp_mst_topology_mgr { > > struct device *dev; > - struct drm_dp_mst_topology_cbs *cbs; > + const struct drm_dp_mst_topology_cbs *cbs; > int max_dpcd_transaction_bytes; > struct drm_dp_aux *aux; /* auxch for this topology mgr to use */ > int max_payloads; > diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c > index 94323f5..8a02225 100644 > --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c > +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c > @@ -329,7 +329,7 @@ static void radeon_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -struct drm_dp_mst_topology_cbs mst_cbs = { > +const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = radeon_dp_add_mst_connector, > .register_connector = radeon_dp_register_mst_connector, > .destroy_connector = radeon_dp_destroy_mst_connector, > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > index e2f515d..fa0dabf 100644 > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > @@ -534,7 +534,7 @@ static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -static struct drm_dp_mst_topology_cbs mst_cbs = { > +static const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = intel_dp_add_mst_connector, > .register_connector = intel_dp_register_mst_connector, > .destroy_connector = intel_dp_destroy_mst_connector, > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch