From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Mon, 4 Jan 2016 09:24:32 +0100 Subject: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM In-Reply-To: <2621741.YulfsnvZOh@wuerfel> References: <4194408.X82ccDjh5X@wuerfel> <2621741.YulfsnvZOh@wuerfel> Message-ID: <20160104082432.GC23797@ulmo> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 01, 2016 at 03:39:17PM +0100, Arnd Bergmann wrote: > The hdlcd_pm_suspend and hdlcd_pm_resume are intentionally unused > when CONFIG_PM is not set in this driver, and we get a compiler warning > for this: > > drivers/gpu/drm/arm/hdlcd_drv.c:521:12: warning: 'hdlcd_pm_suspend' defined but not used [-Wunused-function] > drivers/gpu/drm/arm/hdlcd_drv.c:536:12: warning: 'hdlcd_pm_resume' defined but not used [-Wunused-function] > > This adds a __maybe_unused annotation for the two functions, to let > the compiler know this is the intended behavior. This is better than > an #ifdef as it improves the compile time coverage of the code and it > looks nicer. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thierry Reding -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Date: Mon, 4 Jan 2016 09:24:32 +0100 Message-ID: <20160104082432.GC23797@ulmo> References: <4194408.X82ccDjh5X@wuerfel> <2621741.YulfsnvZOh@wuerfel> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1432312404==" Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id A35056E127 for ; Mon, 4 Jan 2016 00:24:34 -0800 (PST) Received: by mail-wm0-f47.google.com with SMTP id f206so163750995wmf.0 for ; Mon, 04 Jan 2016 00:24:34 -0800 (PST) In-Reply-To: <2621741.YulfsnvZOh@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, Liviu Dudau , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============1432312404== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FsscpQKzF/jJk6ya" Content-Disposition: inline --FsscpQKzF/jJk6ya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 01, 2016 at 03:39:17PM +0100, Arnd Bergmann wrote: > The hdlcd_pm_suspend and hdlcd_pm_resume are intentionally unused > when CONFIG_PM is not set in this driver, and we get a compiler warning > for this: >=20 > drivers/gpu/drm/arm/hdlcd_drv.c:521:12: warning: 'hdlcd_pm_suspend' defin= ed but not used [-Wunused-function] > drivers/gpu/drm/arm/hdlcd_drv.c:536:12: warning: 'hdlcd_pm_resume' define= d but not used [-Wunused-function] >=20 > This adds a __maybe_unused annotation for the two functions, to let > the compiler know this is the intended behavior. This is better than > an #ifdef as it improves the compile time coverage of the code and it > looks nicer. >=20 > Signed-off-by: Arnd Bergmann Reviewed-by: Thierry Reding --FsscpQKzF/jJk6ya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWiixAAAoJEN0jrNd/PrOhUo4QALTK0/WaW4jndo2CnD7rPMVn 3aIBNR/uoaOc2BLKbsp69JSgYFiB9cfCoz4jEs/qhIG1Jq97CJkkzY08O7Dopu0y n/YI2xyapu+aVtPQ3Xqvs261ElmNANusGUrIhLMoa+q9/BK5o+Vpl8RaEvVrPwZZ EC+ekmLvrPfwTtIocg4ulKIdOc3cAj4/OkHPfXp7ySX3HfZw1nBMnkGFhzIG8ZMT IkXQCexS7w4oqkpxFUmE+PVDc1++7YR4pnUIgVhzlnlFhjXaP1Dpk9PZmf5T8y3q 5aZNR+MtHvGdk6WtMeGRKqE67VAN8M4jj2jXQ6nyE5VJpoO5+xekq67FYzYOwxFk 3a1wnd1Nu/I1TUrzDpwhIjH+hyiNoluinC7HY/F1gme+RxRmnRh9Ikl59Co8CJvc cpVUy5GvlvcSYzYShGUDhEMcMY/qVO3q05gz3tETGLrAMZCRn6RfjG5TEwOZGKsd Fmf/exRseaQTVpo4SWIrekJXKkTB5J/HnJ20TLjetnPEW0uF57Iq3AsqiTlnjtqO XJdaxVXRxjI0J2blr7iRoE+A0p4DcMgo+vKdvyuWL6SvafyFabVlmMU08HSsfLwD 35+zsckjxjmdocqp3tcmlLtYR7bPXhHDN3POmcdkM0nhNky1jGvXhLY98VjGt3Dy 9ZcRBoSmxp2K4WCAvaGG =ePXn -----END PGP SIGNATURE----- --FsscpQKzF/jJk6ya-- --===============1432312404== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1432312404==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbcADIYg (ORCPT ); Mon, 4 Jan 2016 03:24:36 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:32880 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbcADIYe (ORCPT ); Mon, 4 Jan 2016 03:24:34 -0500 Date: Mon, 4 Jan 2016 09:24:32 +0100 From: Thierry Reding To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Message-ID: <20160104082432.GC23797@ulmo> References: <4194408.X82ccDjh5X@wuerfel> <2621741.YulfsnvZOh@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FsscpQKzF/jJk6ya" Content-Disposition: inline In-Reply-To: <2621741.YulfsnvZOh@wuerfel> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FsscpQKzF/jJk6ya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 01, 2016 at 03:39:17PM +0100, Arnd Bergmann wrote: > The hdlcd_pm_suspend and hdlcd_pm_resume are intentionally unused > when CONFIG_PM is not set in this driver, and we get a compiler warning > for this: >=20 > drivers/gpu/drm/arm/hdlcd_drv.c:521:12: warning: 'hdlcd_pm_suspend' defin= ed but not used [-Wunused-function] > drivers/gpu/drm/arm/hdlcd_drv.c:536:12: warning: 'hdlcd_pm_resume' define= d but not used [-Wunused-function] >=20 > This adds a __maybe_unused annotation for the two functions, to let > the compiler know this is the intended behavior. This is better than > an #ifdef as it improves the compile time coverage of the code and it > looks nicer. >=20 > Signed-off-by: Arnd Bergmann Reviewed-by: Thierry Reding --FsscpQKzF/jJk6ya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWiixAAAoJEN0jrNd/PrOhUo4QALTK0/WaW4jndo2CnD7rPMVn 3aIBNR/uoaOc2BLKbsp69JSgYFiB9cfCoz4jEs/qhIG1Jq97CJkkzY08O7Dopu0y n/YI2xyapu+aVtPQ3Xqvs261ElmNANusGUrIhLMoa+q9/BK5o+Vpl8RaEvVrPwZZ EC+ekmLvrPfwTtIocg4ulKIdOc3cAj4/OkHPfXp7ySX3HfZw1nBMnkGFhzIG8ZMT IkXQCexS7w4oqkpxFUmE+PVDc1++7YR4pnUIgVhzlnlFhjXaP1Dpk9PZmf5T8y3q 5aZNR+MtHvGdk6WtMeGRKqE67VAN8M4jj2jXQ6nyE5VJpoO5+xekq67FYzYOwxFk 3a1wnd1Nu/I1TUrzDpwhIjH+hyiNoluinC7HY/F1gme+RxRmnRh9Ikl59Co8CJvc cpVUy5GvlvcSYzYShGUDhEMcMY/qVO3q05gz3tETGLrAMZCRn6RfjG5TEwOZGKsd Fmf/exRseaQTVpo4SWIrekJXKkTB5J/HnJ20TLjetnPEW0uF57Iq3AsqiTlnjtqO XJdaxVXRxjI0J2blr7iRoE+A0p4DcMgo+vKdvyuWL6SvafyFabVlmMU08HSsfLwD 35+zsckjxjmdocqp3tcmlLtYR7bPXhHDN3POmcdkM0nhNky1jGvXhLY98VjGt3Dy 9ZcRBoSmxp2K4WCAvaGG =ePXn -----END PGP SIGNATURE----- --FsscpQKzF/jJk6ya--