All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: re: omapfb: copy omapdss & displays for omapfb
Date: Mon, 04 Jan 2016 13:27:54 +0000	[thread overview]
Message-ID: <20160104132754.GA26552@mwanda> (raw)
In-Reply-To: <20160104132534.GA24840@mwanda>

Hello Tomi Valkeinen,

The patch f76ee892a99e: "omapfb: copy omapdss & displays for omapfb"
from Dec 9, 2015, leads to the following static checker warning:

	drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:213 sharp_ls_get_gpio()
	warn: 'gd' isn't an ERR_PTR

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c
   200  static int sharp_ls_get_gpio(struct device *dev, int gpio, unsigned long flags,
   201                    char *desc, struct gpio_desc **gpiod)
   202  {
   203          struct gpio_desc *gd;
   204          int r;
   205  
   206          *gpiod = NULL;
   207  
   208          r = devm_gpio_request_one(dev, gpio, flags, desc);
   209          if (r)
   210                  return r = -ENOENT ? 0 : r;
   211  
   212          gd = gpio_to_desc(gpio);
   213          if (IS_ERR(gd))
   214                  return PTR_ERR(gd) = -ENOENT ? 0 : PTR_ERR(gd);

This doesn't work.  It's either compiled out (ENOENT) or NULL.

   215  
   216          *gpiod = gd;
   217          return 0;
   218  }

regards,
dan carpenter

      reply	other threads:[~2016-01-04 13:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 13:25 omapfb: copy omapdss & displays for omapfb Dan Carpenter
2016-01-04 13:27 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104132754.GA26552@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.