From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alessandro Zummo Subject: Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c Date: Mon, 4 Jan 2016 14:59:38 +0100 Message-ID: <20160104145938.6c053b5a@linux.lan.towertech.it> References: <1451571295-4193-1-git-send-email-zhangqing@rock-chips.com> <20160104094546.GB32724@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160104094546.GB32724-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Alexandre Belloni Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, zhangqing , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example rk855 is not compatible at all > with the previous implementations? Alexandre is absolutely right. There's no need to rename a driver, it would just piss off people who are used to that name and have it in their scripts. Like when your eth0 gets renamed to some obscure enXXX . -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zabrina.hetzner-de.towertech.it (zabrina.hetzner-de.towertech.it. [178.63.16.19]) by gmr-mx.google.com with ESMTP id s132si1154297wmd.1.2016.01.04.05.59.40 for ; Mon, 04 Jan 2016 05:59:40 -0800 (PST) Date: Mon, 4 Jan 2016 14:59:38 +0100 From: Alessandro Zummo To: Alexandre Belloni Cc: zhangqing , heiko@sntech.de, lee.jones@linaro.org, huangtao@rock-chips.com, zyw@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c Message-ID: <20160104145938.6c053b5a@linux.lan.towertech.it> In-Reply-To: <20160104094546.GB32724@piout.net> References: <1451571295-4193-1-git-send-email-zhangqing@rock-chips.com> <20160104094546.GB32724@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example rk855 is not compatible at all > with the previous implementations? Alexandre is absolutely right. There's no need to rename a driver, it would just piss off people who are used to that name and have it in their scripts. Like when your eth0 gets renamed to some obscure enXXX . -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbcADOKB (ORCPT ); Mon, 4 Jan 2016 09:10:01 -0500 Received: from zabrina.hetzner-de.towertech.it ([178.63.16.19]:51440 "EHLO zabrina.hetzner-de.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbcADOJ6 (ORCPT ); Mon, 4 Jan 2016 09:09:58 -0500 X-Greylist: delayed 616 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Jan 2016 09:09:58 EST Date: Mon, 4 Jan 2016 14:59:38 +0100 From: Alessandro Zummo To: Alexandre Belloni Cc: zhangqing , heiko@sntech.de, lee.jones@linaro.org, huangtao@rock-chips.com, zyw@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c Message-ID: <20160104145938.6c053b5a@linux.lan.towertech.it> In-Reply-To: <20160104094546.GB32724@piout.net> References: <1451571295-4193-1-git-send-email-zhangqing@rock-chips.com> <20160104094546.GB32724@piout.net> Organization: Tower Technologies MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example rk855 is not compatible at all > with the previous implementations? Alexandre is absolutely right. There's no need to rename a driver, it would just piss off people who are used to that name and have it in their scripts. Like when your eth0 gets renamed to some obscure enXXX . -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it