From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/4] nvme: fixes for NVME_IOCTL_IO_CMD on the char device
Date: Mon, 4 Jan 2016 15:08:48 +0000 [thread overview]
Message-ID: <20160104150847.GD31375@localhost.localdomain> (raw)
In-Reply-To: <1450967222-10404-4-git-send-email-hch@lst.de>
On Thu, Dec 24, 2015@03:27:01PM +0100, Christoph Hellwig wrote:
> Make sure we synchronize access to the namespaces list and grab a reference
> to the namespace before doing I/O. Make sure to reject the ioctl if multiple
> namespaces are present as it's entirely unsafe, and warn when using it even
> with a single namespace.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Sagi Grimberg <sagig at mellanox.com>
Okay, I accept the argument for allowing these to "hidden" namespaces
is not sufficiently justified.
Acked-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2016-01-04 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 14:26 namespace list locking and ioctl fixes V2 Christoph Hellwig
2015-12-24 14:26 ` [PATCH 1/4] nvme: Move nvme_freeze/unfreeze_queues to nvme core Christoph Hellwig
2016-01-04 15:11 ` Keith Busch
2015-12-24 14:27 ` [PATCH 2/4] nvme: synchronize access to ctrl->namespaces Christoph Hellwig
2016-01-04 15:10 ` Keith Busch
2015-12-24 14:27 ` [PATCH 3/4] nvme: fixes for NVME_IOCTL_IO_CMD on the char device Christoph Hellwig
2016-01-04 15:08 ` Keith Busch [this message]
2015-12-24 14:27 ` [PATCH 4/4] nvme: make SG_IO support optional Christoph Hellwig
2016-01-03 16:36 ` Sagi Grimberg
2016-01-04 15:19 ` Keith Busch
2016-01-04 16:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104150847.GD31375@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.