From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] pinctrl: mediatek: convert to arch_initcall Date: Mon, 4 Jan 2016 17:12:57 +0000 Message-ID: <20160104171257.GO16023@sirena.org.uk> References: <1450792017-7120-1-git-send-email-djkurtz@chromium.org> <20151230172212.GZ16023@sirena.org.uk> <20151231220712.GD16023@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0Wg1ddIY7KV0vpwL" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Matthias Brugger , Daniel Kurtz , Grant Likely , "linux-arm-kernel@lists.infradead.org" , Yingjoe Chen , Hongzhou Yang , Fabio Estevam , Fabian Frederick , Maoguang Meng , Axel Lin , "open list:PIN CONTROL SUBSYSTEM" , open list , "moderated list:ARM/Mediatek SoC support" List-Id: linux-gpio@vger.kernel.org --0Wg1ddIY7KV0vpwL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 01, 2016 at 06:29:15PM +0100, Linus Walleij wrote: > On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger wrote: > > I think what Mark means is, that we define some pinctrl_initcall which > > is a macro to subsys_initcall (or arch_initcall or similar). We apply this > > to all pinctrl drivers including the one from Mediatek. This way at least > > we have a common method and changing the behaviour in the future is > > easier to handle. > That would be pinctrl_soc_initcall() in that case. Just pinctrl_initcall() > would assume it's for all drivers and there is a bunch of them that are just > fine with simple device_initcall()s. OTOH it might be easier to just have an initcall (or fiddle with the link order) for everything to avoid having to think about which drivers things apply to. --0Wg1ddIY7KV0vpwL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWiqgZAAoJECTWi3JdVIfQpQgH/12pMEZ5qu6WTqBMY1CTjyw5 839VULBFUFbheInVXh3vE+U4c351yOVb4oao8PCra1ksnOPgdkYEB6OvjmnF+pcK bfDe15TcX9JKYdhY3WVl3IhUJWslvKuXgxuS2FYVpcP/1vsnGsXR8R0YWZfElsMI e3htl33qOmOTSXZiGyAm0A5PCLvnfkeKhI9M+b7sOY1uUOOcjNAiTWHv5ENXWg5h 9wqK5rRvPU/+HvAyZ+c1lINns/YK2yCcbMuvvcfenFO9AGcQLAd1shTYyDCP7h8D 83RdZ1PwGgmKUm+ETmXegHvgjwKb8IJnhoKFutl2qDm9ZOF+S4gai9Uyv0hhtg4= =D5WS -----END PGP SIGNATURE----- --0Wg1ddIY7KV0vpwL-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 4 Jan 2016 17:12:57 +0000 Subject: [PATCH] pinctrl: mediatek: convert to arch_initcall In-Reply-To: References: <1450792017-7120-1-git-send-email-djkurtz@chromium.org> <20151230172212.GZ16023@sirena.org.uk> <20151231220712.GD16023@sirena.org.uk> Message-ID: <20160104171257.GO16023@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 01, 2016 at 06:29:15PM +0100, Linus Walleij wrote: > On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger wrote: > > I think what Mark means is, that we define some pinctrl_initcall which > > is a macro to subsys_initcall (or arch_initcall or similar). We apply this > > to all pinctrl drivers including the one from Mediatek. This way at least > > we have a common method and changing the behaviour in the future is > > easier to handle. > That would be pinctrl_soc_initcall() in that case. Just pinctrl_initcall() > would assume it's for all drivers and there is a bunch of them that are just > fine with simple device_initcall()s. OTOH it might be easier to just have an initcall (or fiddle with the link order) for everything to avoid having to think about which drivers things apply to. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: