From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/radeon: Update radeon_get_vblank_counter_kms() Date: Mon, 4 Jan 2016 18:19:45 +0100 Message-ID: <20160104171945.GB29079@ulmo> References: <1451922273-19458-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0587831330==" Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C0AB6E4B6 for ; Mon, 4 Jan 2016 09:19:48 -0800 (PST) Received: by mail-wm0-f68.google.com with SMTP id f206so29540429wmf.2 for ; Mon, 04 Jan 2016 09:19:48 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============0587831330== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+" Content-Disposition: inline --jho1yZJdad60DJr+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 04, 2016 at 11:45:05AM -0500, Alex Deucher wrote: > On Mon, Jan 4, 2016 at 10:44 AM, Thierry Reding > wrote: > > From: Thierry Reding > > > > Commit 88e72717c2de ("drm/irq: Use unsigned int pipe in public API") > > updated the prototype of this function but not the implementation. This > > wasn't noticed even through compile tests because the prototype is part > > of the source file that uses it and hence the compiler won't know the > > prototype when it compiles the implementation. > > > > The right thing would've been to move the prototype to a header that's > > included in radeon_kms.c so that the implementation signature could be > > checked against it, but the closest thing would've been radeon_drv.h > > and including that results in a lot of build errors, so we'll leave it > > as is for now. > > > > Cc: Christian K=C3=B6nig > > Cc: Alex Deucher > > Signed-off-by: Thierry Reding > > --- > > Changes in v2: > > - remove unnecessary check for unsigned int < 0 >=20 > I had applied your previous patch before Michel's feedback so it's > already in drm-next, any change you could spin a new patch to just > drop the < 0 check? Done. Thierry --jho1yZJdad60DJr+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWiqmuAAoJEN0jrNd/PrOhWzQQAKBgiuStDYvi7KZKLGVZACAa HR03zaugz6S6OaZN4FCObO7kOqfWQTJZvHxufYMnIE+/0g8KNQH2dxSoMKj04r8C UM+ISm7npYdNt/odx9abd3OLkWBUwsN9n0jNhv6EjAbNddm9L5Xzc8x2Hz2Mhv5m ve62SX6ik+dV+uMoyqtwG9TazJR3vZDyer56z/tn/girnnYZXIff2Th8itJ5otYy ToyDM4TiYjyVC6qlVTKga9jNY7s97BPJQ1qo0i4oOowxylipRyVV/eIi8avJ9Obg ZsrCAUMMkmo7Cqsik6F0ly/SbdQvbJa/Wmg2Ha3+ftJyn07olkJ+zzCeBEjYa54w PkuUIP+Rk8Hu3up7RoZZuy3QDzHVLUHR4L8K7ZVcvcsfy/AS6nMD7VWvyzxEsd6T OWFXf7rDAwUlCq2DJgVMvkk0jq28e0w48Cf/upqhVtNh/BuNVnEwxthp3sLajDAc um/w3v6lw+ZXZAtQ1X3ePBYDRjZ3BlD7ZFKPWwZiUbqG/ol6k+9jUxRXZU46v/jW mlAC/YR2UrO/u5R8WkudhilTz9ZRJeokWsI8TnZ8Nzr8MTAHtnWa48dmFG+EOugq WX8LXUMNOSfat5WvZGbzZElVERec9gE1QaOWshhpYcrgXi9mxGtEIBtACpufaGZE UB/BKhQb/1pHITlA22pN =3zFz -----END PGP SIGNATURE----- --jho1yZJdad60DJr+-- --===============0587831330== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0587831330==--