From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
"Martin Wilck" <Martin.Wilck@ts.fujitsu.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter
Date: Mon, 4 Jan 2016 11:27:53 -0700 [thread overview]
Message-ID: <20160104182753.GD20016@obsidianresearch.com> (raw)
In-Reply-To: <20160103172650.GD4155@intel.com>
On Sun, Jan 03, 2016 at 07:26:50PM +0200, Jarkko Sakkinen wrote:
> > @@ -695,8 +685,8 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info,
> > #endif
> >
> > chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res);
> > - if (!chip->vendor.iobase)
> > - return -EIO;
> > + if (IS_ERR(chip->vendor.iobase))
> > + return PTR_ERR(chip->vendor.iobase);
>
> Isn't this a regression in the descendig patch in this series?
Oh yes, good catch.
The fix from Martin got rebased onto the wrong patch by accident.
Jason
next prev parent reply other threads:[~2016-01-04 18:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 18:23 [PATCH v3 0/7] tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-12-17 18:23 ` [PATCH v3 1/7] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Jason Gunthorpe
[not found] ` <1450376600-6970-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:09 ` Jarkko Sakkinen
2016-01-03 17:09 ` Jarkko Sakkinen
[not found] ` <20160103170906.GA4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:23 ` Jason Gunthorpe
2016-01-04 18:23 ` Jason Gunthorpe
[not found] ` <20160104182317.GB20016-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-04 18:49 ` Jarkko Sakkinen
2016-01-04 18:49 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
[not found] ` <1450376600-6970-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:20 ` Jarkko Sakkinen
2016-01-03 17:20 ` Jarkko Sakkinen
[not found] ` <20160103172040.GB4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:24 ` Jason Gunthorpe
2016-01-04 18:24 ` Jason Gunthorpe
[not found] ` <20160104182442.GC20016-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-04 18:32 ` Jarkko Sakkinen
2016-01-04 18:32 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2 Jason Gunthorpe
[not found] ` <1450376600-6970-4-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-18 9:34 ` Jarkko Sakkinen
2015-12-18 9:34 ` Jarkko Sakkinen
2015-12-18 16:51 ` Jason Gunthorpe
[not found] ` <20151218165127.GC7354-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-20 12:34 ` Jarkko Sakkinen
2015-12-20 12:34 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 4/7] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
[not found] ` <1450376600-6970-5-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:23 ` Jarkko Sakkinen
2016-01-03 17:23 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2016-01-03 17:26 ` Jarkko Sakkinen
2016-01-04 18:27 ` Jason Gunthorpe [this message]
2015-12-17 18:23 ` [PATCH v3 6/7] tpm_crb: Drop le32_to_cpu(ioread32(..)) Jason Gunthorpe
[not found] ` <1450376600-6970-7-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:28 ` Jarkko Sakkinen
2016-01-03 17:28 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Jason Gunthorpe
[not found] ` <1450376600-6970-8-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:32 ` Jarkko Sakkinen
2016-01-03 17:32 ` Jarkko Sakkinen
[not found] ` <20160103173213.GF4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:30 ` Jason Gunthorpe
2016-01-04 18:30 ` Jason Gunthorpe
2016-01-04 19:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104182753.GD20016@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Martin.Wilck@ts.fujitsu.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.