From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Date: Mon, 4 Jan 2016 11:30:25 -0700 Message-ID: <20160104183025.GE20016@obsidianresearch.com> References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com> <1450376600-6970-8-git-send-email-jgunthorpe@obsidianresearch.com> <20160103173213.GF4155@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160103173213.GF4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: Martin Wilck , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Jan 03, 2016 at 07:32:13PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 17, 2015 at 11:23:20AM -0700, Jason Gunthorpe wrote: > > To support the force mode in tpm_tis we need to use resource locking > > in tpm_crb as well, via devm_ioremap_resource. > > > > The light restructuring better aligns crb and tis and makes it easier > > to see the that new changes make sense. > > This patch mixes two items: restructing and actual change. Do you have a suggestion how to split this? Everything is done for a reason, it isn't just churn for the sake of churn. Jason ------------------------------------------------------------------------------ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752062AbcADSa2 (ORCPT ); Mon, 4 Jan 2016 13:30:28 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:50623 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbcADSa1 (ORCPT ); Mon, 4 Jan 2016 13:30:27 -0500 Date: Mon, 4 Jan 2016 11:30:25 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Wilck , Peter Huewe , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Message-ID: <20160104183025.GE20016@obsidianresearch.com> References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com> <1450376600-6970-8-git-send-email-jgunthorpe@obsidianresearch.com> <20160103173213.GF4155@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160103173213.GF4155@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 03, 2016 at 07:32:13PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 17, 2015 at 11:23:20AM -0700, Jason Gunthorpe wrote: > > To support the force mode in tpm_tis we need to use resource locking > > in tpm_crb as well, via devm_ioremap_resource. > > > > The light restructuring better aligns crb and tis and makes it easier > > to see the that new changes make sense. > > This patch mixes two items: restructing and actual change. Do you have a suggestion how to split this? Everything is done for a reason, it isn't just churn for the sake of churn. Jason