All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Heiko Schocher <hs@denx.de>, Frans Klaver <fransklaver@gmail.com>
Subject: Re: [PATCH for-4.4] mtd: fix cmdlinepart parser, early naming for auto-filled MTD
Date: Mon, 4 Jan 2016 10:56:46 -0800	[thread overview]
Message-ID: <20160104185646.GD109450@google.com> (raw)
In-Reply-To: <1449878281-94986-1-git-send-email-computersforpeace@gmail.com>

On Fri, Dec 11, 2015 at 03:58:01PM -0800, Brian Norris wrote:
> Commit 807f16d4db95 ("mtd: core: set some defaults when dev.parent is
> set") attempted to provide some default settings for MTDs that
>  (a) assign the parent device and
>  (b) don't provide their own name or owner
> 
> However, this isn't a perfect drop-in replacement for the boilerplate
> found in some drivers, because the MTD name is used by partition
> parsers like cmdlinepart, but the name isn't set until add_mtd_device(),
> after the parsing is completed. This means cmdlinepart sees a NULL name
> and therefore will not work properly.
> 
> Fix this by moving the default name and owner assignment to be first in
> the MTD registration process.
> 
> Fixes: 807f16d4db95 ("mtd: core: set some defaults when dev.parent is set")
> Reported-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Frans Klaver <fransklaver@gmail.com>
> ---
> Heiko, can you provide testing feedback (e.g., 'Tested-by: ...')?

Applied this patch to linux-mtd.git, even though it doesn't completely
fix the reported problem -- it fixes many other MTD drivers, but
drivers/mtd/nand/ has an additional issue. I'll resend the additional
patch that fixes Heiko's problem completely in a bit.

Brian

      parent reply	other threads:[~2016-01-04 18:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 23:58 [PATCH for-4.4] mtd: fix cmdlinepart parser, early naming for auto-filled MTD Brian Norris
2015-12-12  4:45 ` Heiko Schocher
2015-12-12  5:39   ` Brian Norris
2015-12-14 19:24     ` Brian Norris
2015-12-15  6:51       ` Heiko Schocher
2016-01-04 18:56 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104185646.GD109450@google.com \
    --to=computersforpeace@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=fransklaver@gmail.com \
    --cc=hs@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.