All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Julian Wollrath <jwollrath@web.de>
Cc: Jiri Kosina <jkosina@suse.cz>, xfs@oss.sgi.com
Subject: Re: Suspend does not work with v4.4-rc8
Date: Tue, 5 Jan 2016 06:40:14 +1100	[thread overview]
Message-ID: <20160104194014.GD19802@dastard> (raw)
In-Reply-To: <20160104202611.5b100540@saldaea>

On Mon, Jan 04, 2016 at 08:26:11PM +0100, Julian Wollrath wrote:
> Hi,
> 
> suspending (either to RAM or disk) fails with 4.4-rc8 with the
> following message while v4.3.3 worked fine:
> 
> kernel: Freezing of tasks failed after 20.006 seconds (2 tasks refusing to freeze, wq_bu_busy=0):
> kernel: xfsaild/dm-1    S 0000000000014100     0   283      2 0x00000000
> kernel:  ffff880213f53e10 ffffffff8180e4c0 ffff880213f05040 0000000000000000
> kernel:  0000000000000000 ffff880213f54000 0000000000000000 0000000000000000
> kernel:  ffff8800ca389e40 ffff8800ca392000 ffff880213f53ed0 ffffffff814cd8ac
> kernel: Call Trace:
> kernel:  [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> kernel:  [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> kernel:  [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel:  [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel:  [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> kernel:  [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel:  [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70 
> kernel:  [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel: xfsaild/sda1    S 0000000000014100     0   591      2 0x00000000
> kernel:  ffff88021193be10 ffff8802159c4dc0 ffff880213ab9340 0000000000000000
> kernel:  0000000000000000 ffff88021193c000 0000000000000000 0000000000000000
> kernel:  ffff8800ca2a4240 ffff880214eea000 ffff88021193bed0 ffffffff814cd8ac
> kernel: Call Trace:
> kernel:  [<ffffffff814cd8ac>] ? schedule+0x2c/0x70
> kernel:  [<ffffffff8125e37d>] ? xfsaild+0x4fd/0x5b0
> kernel:  [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel:  [<ffffffff8125de80>] ? xfs_trans_ail_cursor_first+0x80/0x80
> kernel:  [<ffffffff8108bd18>] ? kthread+0xb8/0xd0
> kernel:  [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> kernel:  [<ffffffff814d115f>] ? ret_from_fork+0x3f/0x70 
> kernel:  [<ffffffff8108bc60>] ? kthread_worker_fn+0x150/0x150
> 
> Please tell me what more information you need to be able to fix this
> issue.

The freezer detection is broken. The thread is sleeping in schedule
until a wakeup occurs some time in the future, which means it cannot
"enter then freezer" because it's not a running thread. This is a
problem introduced by commit 24ba16b ("xfs: clear PF_NOFREEZE for
xfsaild kthread").

Jiri, I'm tempted just to revert this change - if the freezer
doesn't detect processes that are not in TASK_RUNNABLE state as
frozeni or can't mark them as frozen, then this change will never
work reliably for XFS....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-01-04 19:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 19:26 Suspend does not work with v4.4-rc8 Julian Wollrath
2016-01-04 19:40 ` Dave Chinner [this message]
2016-01-08 10:44   ` Jiri Kosina
2016-01-08 21:31     ` Dave Chinner
2016-01-14 14:36   ` Julian Wollrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104194014.GD19802@dastard \
    --to=david@fromorbit.com \
    --cc=jkosina@suse.cz \
    --cc=jwollrath@web.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.