From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: blkback name greater than 16 characters issue Date: Mon, 4 Jan 2016 14:51:14 -0500 Message-ID: <20160104195114.GG6309@char.us.oracle.com> References: <20151214164635.GA9191@char.us.oracle.com> <22154.39493.367316.711433@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aGBA8-0007iX-Af for xen-devel@lists.xenproject.org; Mon, 04 Jan 2016 19:51:28 +0000 Content-Disposition: inline In-Reply-To: <22154.39493.367316.711433@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, julien.grall@citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, Jan 04, 2016 at 04:13:57PM +0000, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("blkback name greater than 16 characters issue"): > > Way back in the past Jan pointed out this issue > > http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03505.html > > > > which is that the device name is "blkback.." > > for exmaple: blkback.8.xvda, blkback.11.hda > > I don't understand in what sense this is the `device name'. > > AFAICT from your references we are talking about what appears in `ps' > on BSD. Is that right ? The lack of uniqueness is a problem for > admins and for debugging but not for functionality ? Correct. Just for troubleshooting or such. You can look at 'top' or 'ps' and see which of the blkback threads is eating CPU cycles or such. > > > My desire is to easily correlate the name of the thread with the > > guest config. And that means preserving the 'xvda' or 'hda' or whatever > > the user had in mind. > > > > I believe the domain id is important as well - so we need that. > > > > Which means we are left with the prefix. Should it be 'blkbk' or > > should it be completely eliminated? Meaning we have: > > Surely this string should have something in it which makes it clear > that it's a Xen vbd backend. > > I suggest for xvds > > 1234567890123456 > DOMID.xvdXYNN > > and for the others > > 1234567890123456 > DOMID.xvd-hdXYNN > > It's a shame that DOMID comes first but I can't think of a sane syntax > that puts `x', DOMID, type, and XYNN in that order. OK, let me prep a patch for this shortly. Thank you! > > Ian.