From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing Date: Mon, 4 Jan 2016 15:19:20 -0500 Message-ID: <20160104201920.GA15307@char.us.oracle.com> References: <1450865195-12883-1-git-send-email-paul.durrant@citrix.com> <1450865195-12883-3-git-send-email-paul.durrant@citrix.com> <567AA148.4070207@citrix.com> <9AAE0902D5BC7E449B7C8E4E778ABCD02F711A79@AMSPEX01CL01.citrite.net> <568A4FB8.7070100@citrix.com> <9AAE0902D5BC7E449B7C8E4E778ABCD02F712179@AMSPEX01CL01.citrite.net> <568A54EE.4010605@citrix.com> <9AAE0902D5BC7E449B7C8E4E778ABCD02F71470F@AMSPEX01CL01.citrite.net> <568A5767.5010605@citrix.com> <9AAE0902D5BC7E449B7C8E4E778ABCD02F715A10@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aGBbF-0001LN-LR for xen-devel@lists.xenproject.org; Mon, 04 Jan 2016 20:19:29 +0000 Content-Disposition: inline In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD02F715A10@AMSPEX01CL01.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: "Keir (Xen.org)" , Ian Campbell , "Tim (Xen.org)" , David Vrabel , Jan Beulich , Ian Jackson , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org > > You've put the consumer values into the shared page. I'd rather not have > > to scrutinize your shared ring implementation for other security bugs. > > Similarly, if there's another security issues like XSA-155 I'd rather > > not have to look at another non-standard shared ring implementation. > > Ok. That's a good enough reason. I'll come up with a new prototype. Could I suggest that you make this a more generic one? That is not just limited to network out of band - but other drivers could use it as well. > > > > > IMO, it's you who should be presenting compelling reasons for /not/ > > using the standard infrastructure, not the other way around. > > > > There is no 'standard' here though. There's convention, but that's a different thing. If we're going to have a 'no more variable size message protocols' policy than that needs writing down somewhere. > > Paul > > > David > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel