From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: Suspend To RAM failure in >= 4.1 - bissected to "drm/i915: Track GEN6 page table usage" Date: Mon, 4 Jan 2016 12:35:55 -0800 Message-ID: <20160104203553.GA14063@intel.com> References: <20160104201211.GA5847@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id B41C96E0FD for ; Mon, 4 Jan 2016 12:35:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160104201211.GA5847@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Pavel Machek Cc: intel-gfx@lists.freedesktop.org, Sylvain Munaut , LKML List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMDk6MTI6MTFQTSArMDEwMCwgUGF2ZWwgTWFjaGVrIHdy b3RlOgo+IEhpIQo+IAo+ID4gPiBJIHRoZW4gcmFuIGEgZ2l0IGJpc3NlY3QgYmV0d2VlbiB2NC4w IGFuZCB2NC4xIGZyb20gTGludXMncyB0cmVlIGFuZAo+ID4gPiBmb3VuZCB0aGUgImd1aWx0eSIg Y29tbWl0IHdhcwo+ID4gPgo+ID4gPiBjb21taXQgMzE3YjRlOTAzNjM2MzA1Y2ZlNzAyYWIzZTVi M2Q2ODU0N2E2OWU3Mgo+ID4gPiBBdXRob3I6IEJlbiBXaWRhd3NreSA8YmVuamFtaW4ud2lkYXdz a3lAaW50ZWwuY29tPgo+ID4gPiBEYXRlOiAgIE1vbiBNYXIgMTYgMTY6MDA6NTUgMjAxNSArMDAw MAo+ID4gPgo+ID4gPiAgICAgZHJtL2k5MTU6IEV4dHJhY3QgY29udGV4dCBzd2l0Y2ggc2tpcCBh bmQgYWRkIHBkIGxvYWQgbG9naWMKPiA+IAo+ID4gRGFtbml0LCBwYXN0ZSBmYWlsLgo+ID4gCj4g PiBJIG1lYW50IHRvIHBhc3RlIDoKPiA+IAo+ID4gY29tbWl0IDY3OGQ5NmZiYjNiNTk5NWEyZmRm ZjJiY2E1ZTFhYjRhNDBiN2U5NjgKPiA+IEF1dGhvcjogQmVuIFdpZGF3c2t5IDxiZW5qYW1pbi53 aWRhd3NreUBpbnRlbC5jb20+Cj4gPiBEYXRlOiAgIE1vbiBNYXIgMTYgMTY6MDA6NTYgMjAxNSAr MDAwMAo+ID4gCj4gPiAgICAgZHJtL2k5MTU6IFRyYWNrIEdFTjYgcGFnZSB0YWJsZSB1c2FnZQo+ ID4gCj4gPiAoYXMgaW5kaWNhdGVkIGluIHRoZSB0aXRsZSBhbmQgaW4gdGhlIGdpdCBiaXNlY3Qg bG9nKQo+IAo+IENhbiB5b3UgdmVyaWZ5IHRoYXQgcmV2ZXJ0aW5nIHRoaXMgcGF0Y2ggKG9uIHRv cCBvZiA0LjQ/KSBmaXhlcyBpdD8KPiAKPiBJZiBzbywgaXMgaXQgdGltZSB0byByZXZlcnQgaXQ/ Cj4gCj4gVGhhbmtzLAo+IAkJCQkJCQkJCVBhdmVsCgpJdCdzIGhpZ2hseSB1bmxpa2VseSB5b3Un bGwgYmUgYWJsZSB0byByZXZlcnQgdGhpcyBvbiB0b3Agb2YgNC40LiBVbmZvcnR1bmF0ZWx5LAp0 aGlzIGlzIHRoZSBjb3JuZXJzdG9uZSBvZiBhIHdob2xlIGxvdCBvZiBpbmZyYXN0cnVjdHVyZSBu ZWVkZWQgdG8gc3VwcG9ydCB0aGUKcGVyIHByb2Nlc3MgcGFnZSB0YWJsZXMuCgpJJ20ganVzdCB0 aGUgbWVhc2x5IG9yaWdpbmFsIGF1dGhvciBvZiB0aGUgcGF0Y2guIExvdHMgb2Ygb3RoZXJzIHRy aWVkIHRvIHJpZ2h0Cm15IHdyb25ncywgYW5kIHRoZXkncmUgYmV0dGVyIHN1aXRlZCB0byBkZWJ1 ZyB0aGlzLiBJZiB0aGVyZSBoYXNuJ3QgYmVlbiBtdWNoCnRyYWN0aW9uLCBpdCdzIHByb2JhYmx5 IGJlY2F1c2Ugb2YgdGhlIGhvbGlkYXlzLgoKSSBhc3N1bWUgc3VzcGVuZCB0byBkaXNrIGlzIGFs c28gZmFpbGluZz8KCi0tIApCZW4gV2lkYXdza3ksIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbcADUf5 (ORCPT ); Mon, 4 Jan 2016 15:35:57 -0500 Received: from mga02.intel.com ([134.134.136.20]:51224 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbcADUfy (ORCPT ); Mon, 4 Jan 2016 15:35:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,522,1444719600"; d="scan'208";a="720116757" Date: Mon, 4 Jan 2016 12:35:55 -0800 From: Ben Widawsky To: Pavel Machek Cc: Sylvain Munaut , LKML , intel-gfx@lists.freedesktop.org Subject: Re: Suspend To RAM failure in >= 4.1 - bissected to "drm/i915: Track GEN6 page table usage" Message-ID: <20160104203553.GA14063@intel.com> References: <20160104201211.GA5847@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104201211.GA5847@amd> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 09:12:11PM +0100, Pavel Machek wrote: > Hi! > > > > I then ran a git bissect between v4.0 and v4.1 from Linus's tree and > > > found the "guilty" commit was > > > > > > commit 317b4e903636305cfe702ab3e5b3d68547a69e72 > > > Author: Ben Widawsky > > > Date: Mon Mar 16 16:00:55 2015 +0000 > > > > > > drm/i915: Extract context switch skip and add pd load logic > > > > Damnit, paste fail. > > > > I meant to paste : > > > > commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 > > Author: Ben Widawsky > > Date: Mon Mar 16 16:00:56 2015 +0000 > > > > drm/i915: Track GEN6 page table usage > > > > (as indicated in the title and in the git bisect log) > > Can you verify that reverting this patch (on top of 4.4?) fixes it? > > If so, is it time to revert it? > > Thanks, > Pavel It's highly unlikely you'll be able to revert this on top of 4.4. Unfortunately, this is the cornerstone of a whole lot of infrastructure needed to support the per process page tables. I'm just the measly original author of the patch. Lots of others tried to right my wrongs, and they're better suited to debug this. If there hasn't been much traction, it's probably because of the holidays. I assume suspend to disk is also failing? -- Ben Widawsky, Intel Open Source Technology Center