From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 04 Jan 2016 20:44:24 +0000 Subject: [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields() Message-Id: <20160104204424.GD19867@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie , Jammy Zhou Cc: Alex Deucher , Tom St Denis , kernel-janitors@vger.kernel.org, Rex Zhu , dri-devel@lists.freedesktop.org The cast to uint8_t happens before the right shift so this always sets .m3arb to zero. The cast is actually a no-op so we can remove it. Fixes: 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component') Signed-off-by: Dan Carpenter --- Static analysis stuff. Not tested. diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c index 1d385f4..9031a44 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c @@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr, ps->memory.dllOff = (0 != tmp); - ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) & - ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT; + ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) & + ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT; ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES * pnon_clock_info->ucMinTemperature; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields() Date: Mon, 4 Jan 2016 23:44:24 +0300 Message-ID: <20160104204424.GD19867@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D94B6E0C2 for ; Mon, 4 Jan 2016 12:44:45 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Jammy Zhou Cc: Alex Deucher , Tom St Denis , kernel-janitors@vger.kernel.org, Rex Zhu , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIGNhc3QgdG8gdWludDhfdCBoYXBwZW5zIGJlZm9yZSB0aGUgcmlnaHQgc2hpZnQgc28gdGhp cyBhbHdheXMgc2V0cwoubTNhcmIgdG8gemVyby4gIFRoZSBjYXN0IGlzIGFjdHVhbGx5IGEgbm8t b3Agc28gd2UgY2FuIHJlbW92ZSBpdC4KCkZpeGVzOiAzYmFjZTM1OTE0OTMgKCdkcm0vYW1kL3Bv d2VycGxheTogYWRkIGhhcmR3YXJlIG1hbmFnZXIgc3ViLWNvbXBvbmVudCcpClNpZ25lZC1vZmYt Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KLS0tClN0YXRpYyBh bmFseXNpcyBzdHVmZi4gIE5vdCB0ZXN0ZWQuCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9wb3dlcnBsYXkvaHdtZ3IvcHJvY2Vzc3BwdGFibGVzLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL3Bvd2VycGxheS9od21nci9wcm9jZXNzcHB0YWJsZXMuYwppbmRleCAxZDM4NWY0Li45MDMx YTQ0IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9od21nci9wcm9j ZXNzcHB0YWJsZXMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9od21nci9w cm9jZXNzcHB0YWJsZXMuYwpAQCAtNzM1LDggKzczNSw4IEBAIHN0YXRpYyBpbnQgaW5pdF9ub25f Y2xvY2tfZmllbGRzKHN0cnVjdCBwcF9od21nciAqaHdtZ3IsCiAKIAlwcy0+bWVtb3J5LmRsbE9m ZiA9ICgwICE9IHRtcCk7CiAKLQlwcy0+bWVtb3J5Lm0zYXJiID0gKHVpbnQ4X3QpKGxlMzJfdG9f Y3B1KHBub25fY2xvY2tfaW5mby0+dWxDYXBzQW5kU2V0dGluZ3MpICYKLQkJCQkJCUFUT01fUFBM SUJfTTNBUkJfTUFTSykgPj4gQVRPTV9QUExJQl9NM0FSQl9TSElGVDsKKwlwcy0+bWVtb3J5Lm0z YXJiID0gKGxlMzJfdG9fY3B1KHBub25fY2xvY2tfaW5mby0+dWxDYXBzQW5kU2V0dGluZ3MpICYK KwkJCSAgICBBVE9NX1BQTElCX00zQVJCX01BU0spID4+IEFUT01fUFBMSUJfTTNBUkJfU0hJRlQ7 CiAKIAlwcy0+dGVtcGVyYXR1cmVzLm1pbiA9IFBQX1RFTVBFUkFUVVJFX1VOSVRTX1BFUl9DRU5U SUdSQURFUyAqCiAJCQkJICAgICBwbm9uX2Nsb2NrX2luZm8tPnVjTWluVGVtcGVyYXR1cmU7Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==