From: Andrew Lunn <andrew@lunn.ch>
To: kernel-janitors@vger.kernel.org
Subject: Re: phy: micrel: Add ethtool statistics counters
Date: Mon, 04 Jan 2016 21:20:02 +0000 [thread overview]
Message-ID: <20160104212002.GD7485@lunn.ch> (raw)
In-Reply-To: <20160104211545.GA9452@mwanda>
On Tue, Jan 05, 2016 at 12:15:45AM +0300, Dan Carpenter wrote:
> Hello Andrew Lunn,
>
> The patch 2b2427d06426: "phy: micrel: Add ethtool statistics
> counters" from Dec 30, 2015, leads to the following static checker
> warning:
>
> drivers/net/phy/micrel.c:609 kszphy_get_stat()
> warn: unsigned 'val' is never less than zero.
>
> drivers/net/phy/micrel.c
> 602 static u64 kszphy_get_stat(struct phy_device *phydev, int i)
> 603 {
> 604 struct kszphy_hw_stat stat = kszphy_hw_stats[i];
> 605 struct kszphy_priv *priv = phydev->priv;
> 606 u64 val;
> 607
> 608 val = phy_read(phydev, stat.reg);
> 609 if (val < 0) {
> ^^^^^^^
> Unpossible!
Yep, will fix.
You might see the same from the Marvell phy driver...
Andrew
next prev parent reply other threads:[~2016-01-04 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 21:15 phy: micrel: Add ethtool statistics counters Dan Carpenter
2016-01-04 21:20 ` Andrew Lunn [this message]
2016-01-04 22:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104212002.GD7485@lunn.ch \
--to=andrew@lunn.ch \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.