From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH 3/8] cgroup: introduce cgroup namespaces Date: Mon, 4 Jan 2016 16:47:27 -0500 Message-ID: <20160104214727.GA10618@cmpxchg.org> References: <1451937294-22589-1-git-send-email-serge.hallyn@ubuntu.com> <1451937294-22589-4-git-send-email-serge.hallyn@ubuntu.com> <20160104202053.GA23238@mail.hallyn.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20160104202053.GA23238-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Serge E. Hallyn" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, adityakali-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lxc-devel-cunTk1MwBs9qMoObBWhMNEqPaTDuhLve2LY78lusg7I@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, Serge Hallyn On Mon, Jan 04, 2016 at 02:20:53PM -0600, Serge E. Hallyn wrote: > On Mon, Jan 04, 2016 at 01:54:48PM -0600, serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org wrote: > > @@ -2166,6 +2178,43 @@ static struct file_system_type cgroup2_fs_type = { > > .kill_sb = cgroup_kill_sb, > > }; > > > > +char * > > Sorry, that one should be 'static char *' Lol, that took a while to find. Please don't quote over 500 lines to comment on a trivial issue of one line. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753475AbcADVsA (ORCPT ); Mon, 4 Jan 2016 16:48:00 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:50890 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbcADVr6 (ORCPT ); Mon, 4 Jan 2016 16:47:58 -0500 Date: Mon, 4 Jan 2016 16:47:27 -0500 From: Johannes Weiner To: "Serge E. Hallyn" Cc: linux-kernel@vger.kernel.org, adityakali@google.com, tj@kernel.org, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, lxc-devel@lists.linuxcontainers.org, akpm@linux-foundation.org, ebiederm@xmission.com, gregkh@linuxfoundation.org, lizefan@huawei.com, Serge Hallyn Subject: Re: [PATCH 3/8] cgroup: introduce cgroup namespaces Message-ID: <20160104214727.GA10618@cmpxchg.org> References: <1451937294-22589-1-git-send-email-serge.hallyn@ubuntu.com> <1451937294-22589-4-git-send-email-serge.hallyn@ubuntu.com> <20160104202053.GA23238@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104202053.GA23238@mail.hallyn.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 02:20:53PM -0600, Serge E. Hallyn wrote: > On Mon, Jan 04, 2016 at 01:54:48PM -0600, serge.hallyn@ubuntu.com wrote: > > @@ -2166,6 +2178,43 @@ static struct file_system_type cgroup2_fs_type = { > > .kill_sb = cgroup_kill_sb, > > }; > > > > +char * > > Sorry, that one should be 'static char *' Lol, that took a while to find. Please don't quote over 500 lines to comment on a trivial issue of one line.