From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [V5, 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Date: Mon, 4 Jan 2016 21:19:44 -0600 Message-ID: <20160105031944.GA4139@hector.attlocal.net> References: <1447760727-4897-2-git-send-email-sricharan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1447760727-4897-2-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sricharan R Cc: iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Tue, Nov 17, 2015 at 05:15:22PM +0530, Sricharan R wrote: > qup_wait_writeready waits only on a output fifo empty event. > Change the same function to accept the event and data length > to wait as parameters. This way the same function can be used for > timeouts in other places as well. > > Signed-off-by: Sricharan R Looks good to me. Reviewed-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.gross@linaro.org (Andy Gross) Date: Mon, 4 Jan 2016 21:19:44 -0600 Subject: [V5, 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts In-Reply-To: <1447760727-4897-2-git-send-email-sricharan@codeaurora.org> References: <1447760727-4897-2-git-send-email-sricharan@codeaurora.org> Message-ID: <20160105031944.GA4139@hector.attlocal.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 17, 2015 at 05:15:22PM +0530, Sricharan R wrote: > qup_wait_writeready waits only on a output fifo empty event. > Change the same function to accept the event and data length > to wait as parameters. This way the same function can be used for > timeouts in other places as well. > > Signed-off-by: Sricharan R Looks good to me. Reviewed-by: Andy Gross From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbcAEDTv (ORCPT ); Mon, 4 Jan 2016 22:19:51 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35349 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884AbcAEDTr (ORCPT ); Mon, 4 Jan 2016 22:19:47 -0500 Date: Mon, 4 Jan 2016 21:19:44 -0600 From: Andy Gross To: Sricharan R Cc: iivanov@mm-sol.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, galak@codeaurora.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, agross@codeaurora.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [V5, 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Message-ID: <20160105031944.GA4139@hector.attlocal.net> References: <1447760727-4897-2-git-send-email-sricharan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447760727-4897-2-git-send-email-sricharan@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2015 at 05:15:22PM +0530, Sricharan R wrote: > qup_wait_writeready waits only on a output fifo empty event. > Change the same function to accept the event and data length > to wait as parameters. This way the same function can be used for > timeouts in other places as well. > > Signed-off-by: Sricharan R Looks good to me. Reviewed-by: Andy Gross