From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Date: Tue, 5 Jan 2016 12:37:50 +0100 Message-ID: <20160105113750.GL22661@pali> References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <20151224190237.GA17343@pali> <5681A322.2090204@gmail.com> <50067860.qzAxcgo8L4@wuerfel> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=82kVtVTWGtpTEzzd0SD3XN3Fv2+J7ZkVolF51Ot3a8A=; b=TyP1c0vIS2Pzfs/g9oJHOJBy6gnCg84TXJLUpD3dCJXgVk9IKCbMpz7PzejrL7TULz 9LM5/yoHBLfgEMfTMebMPQOF3226MUPTXezJvyPKvzmF0p3ijXlL4n7/qEaAGtmn+f2a gPYLh2WgEpLaUPqtqn0o4jUiSsRvXXR9UtnmMtrGlT+QfRdBouzDPbf/VWipGiKAp7Hq 88JUJN1jAz/AzApITlfl5/15Y7lr+n1yuVJzVx9tP3Gr8VaObDa4WM5FHyxWjYwnP6mT riY3HkaxGOZWJb3CuPdc1Y5O/aNdTjgS2vJLIRy86qqA0RC6dG64rFMh1pHPRm97WPKp yumQ== Content-Disposition: inline In-Reply-To: <50067860.qzAxcgo8L4@wuerfel> Sender: devicetree-spec-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="macroman" To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ivaylo Dimitrov , Laura Abbott , Tony Lindgren , Sebastian Reichel , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Devicetree Spec List , Rob Herring , Pavel Machek , Grant Likely , Russell King , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas =?utf-8?Q?F=C3=A4rber?= On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote: > On Monday 28 December 2015 13:01:22 Frank Rowand wrote: > >=20 > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revisi= on" > > property. > >=20 > > If the use of /revision is limited to being a location to hold an A= TAG > > value to pass to the global variable system_rev, then it would make > > sense to just copy directly from the ATAG value into system_rev in = the > > same board file where you are copying the ATAGs. >=20 > Agreed. That would be simpler, and avoid a situation where someone re= lies > on the /revision property in DT to be set from the atags compat code > (preventing an upgrade to a newer bootloader), or on the system_rev v= ariable > to be the same across multiple boot loaders, in the absence of other > kernel code setting it. So, set system_rev only for Nokia N900? At same place where is called save_atags()? --=20 Pali Roh=C3=A1r pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Date: Tue, 5 Jan 2016 12:37:50 +0100 Message-ID: <20160105113750.GL22661@pali> References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <20151224190237.GA17343@pali> <5681A322.2090204@gmail.com> <50067860.qzAxcgo8L4@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <50067860.qzAxcgo8L4@wuerfel> Sender: devicetree-spec-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ivaylo Dimitrov , Laura Abbott , Tony Lindgren , Sebastian Reichel , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Devicetree Spec List , Rob Herring , Pavel Machek , Grant Likely , Russell King , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas =?utf-8?Q?F=C3=A4rber?= List-Id: linux-omap@vger.kernel.org On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote: > On Monday 28 December 2015 13:01:22 Frank Rowand wrote: > >=20 > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revisi= on" > > property. > >=20 > > If the use of /revision is limited to being a location to hold an A= TAG > > value to pass to the global variable system_rev, then it would make > > sense to just copy directly from the ATAG value into system_rev in = the > > same board file where you are copying the ATAGs. >=20 > Agreed. That would be simpler, and avoid a situation where someone re= lies > on the /revision property in DT to be set from the atags compat code > (preventing an upgrade to a newer bootloader), or on the system_rev v= ariable > to be the same across multiple boot loaders, in the absence of other > kernel code setting it. So, set system_rev only for Nokia N900? At same place where is called save_atags()? --=20 Pali Roh=C3=A1r pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: pali.rohar@gmail.com (Pali =?utf-8?B?Um9ow6Fy?=) Date: Tue, 5 Jan 2016 12:37:50 +0100 Subject: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" In-Reply-To: <50067860.qzAxcgo8L4@wuerfel> References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <20151224190237.GA17343@pali> <5681A322.2090204@gmail.com> <50067860.qzAxcgo8L4@wuerfel> Message-ID: <20160105113750.GL22661@pali> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote: > On Monday 28 December 2015 13:01:22 Frank Rowand wrote: > > > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revision" > > property. > > > > If the use of /revision is limited to being a location to hold an ATAG > > value to pass to the global variable system_rev, then it would make > > sense to just copy directly from the ATAG value into system_rev in the > > same board file where you are copying the ATAGs. > > Agreed. That would be simpler, and avoid a situation where someone relies > on the /revision property in DT to be set from the atags compat code > (preventing an upgrade to a newer bootloader), or on the system_rev variable > to be the same across multiple boot loaders, in the absence of other > kernel code setting it. So, set system_rev only for Nokia N900? At same place where is called save_atags()? -- Pali Roh?r pali.rohar at gmail.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbcAELh6 (ORCPT ); Tue, 5 Jan 2016 06:37:58 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34567 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbcAELhx (ORCPT ); Tue, 5 Jan 2016 06:37:53 -0500 Date: Tue, 5 Jan 2016 12:37:50 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, frowand.list@gmail.com, Ivaylo Dimitrov , Laura Abbott , Tony Lindgren , Sebastian Reichel , Will Deacon , linux-kernel@vger.kernel.org, Devicetree Spec List , Rob Herring , Pavel Machek , Grant Likely , Russell King , linux-omap@vger.kernel.org, Andreas =?utf-8?Q?F=C3=A4rber?= Subject: Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Message-ID: <20160105113750.GL22661@pali> References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <20151224190237.GA17343@pali> <5681A322.2090204@gmail.com> <50067860.qzAxcgo8L4@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50067860.qzAxcgo8L4@wuerfel> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote: > On Monday 28 December 2015 13:01:22 Frank Rowand wrote: > > > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revision" > > property. > > > > If the use of /revision is limited to being a location to hold an ATAG > > value to pass to the global variable system_rev, then it would make > > sense to just copy directly from the ATAG value into system_rev in the > > same board file where you are copying the ATAGs. > > Agreed. That would be simpler, and avoid a situation where someone relies > on the /revision property in DT to be set from the atags compat code > (preventing an upgrade to a newer bootloader), or on the system_rev variable > to be the same across multiple boot loaders, in the absence of other > kernel code setting it. So, set system_rev only for Nokia N900? At same place where is called save_atags()? -- Pali Rohár pali.rohar@gmail.com