From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/15] drm/i915/dsi: be defensive about out of bounds operation byte Date: Tue, 5 Jan 2016 15:15:23 +0100 Message-ID: <20160105141522.GG8076@phenom.ffwll.local> References: <01c71ac89a9db8bc7b8ae0fb05c50a5fae362dc4.1450702954.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D0E46E08A for ; Tue, 5 Jan 2016 06:15:26 -0800 (PST) Received: by mail-wm0-f44.google.com with SMTP id u188so24752166wmu.1 for ; Tue, 05 Jan 2016 06:15:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <01c71ac89a9db8bc7b8ae0fb05c50a5fae362dc4.1450702954.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Deepak M , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMjEsIDIwMTUgYXQgMDM6MTA6NTlQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVW50aWUgdGhlIFZCVCBiYXNlZCBnZW5lcmljIHBhbmVsIGRyaXZlciBmcm9tIHRoZSBW QlQgcGFyc2luZywgc28gdGhhdAo+IHRoZSB0d28gZG9uJ3QgaGF2ZSB0byBiZSB1cGRhdGVkIGlu IGxvY2tzdGVwLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92 YnQuYyB8IDIyICsrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5z ZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RzaV9wYW5lbF92YnQuYwo+IGluZGV4IDQ1NTEyZTBkZjU3YS4uYmE1MzU1NTA2NTkwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYwo+IEBAIC0y MzIsMTEgKzIzMiw5IEBAIHN0YXRpYyBjb25zdCB1OCAqbWlwaV9leGVjX2dwaW8oc3RydWN0IGlu dGVsX2RzaSAqaW50ZWxfZHNpLCBjb25zdCB1OCAqZGF0YSkKPiAgdHlwZWRlZiBjb25zdCB1OCAq ICgqZm5fbWlwaV9lbGVtX2V4ZWMpKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwKPiAgCQkJ CQljb25zdCB1OCAqZGF0YSk7Cj4gIHN0YXRpYyBjb25zdCBmbl9taXBpX2VsZW1fZXhlYyBleGVj X2VsZW1bXSA9IHsKPiAtCU5VTEwsIC8qIHJlc2VydmVkICovCj4gLQltaXBpX2V4ZWNfc2VuZF9w YWNrZXQsCj4gLQltaXBpX2V4ZWNfZGVsYXksCj4gLQltaXBpX2V4ZWNfZ3BpbywKPiAtCU5VTEws IC8qIHN0YXR1cyByZWFkOyBsYXRlciAqLwo+ICsJW01JUElfU0VRX0VMRU1fU0VORF9QS1RdID0g bWlwaV9leGVjX3NlbmRfcGFja2V0LAo+ICsJW01JUElfU0VRX0VMRU1fREVMQVldID0gbWlwaV9l eGVjX2RlbGF5LAo+ICsJW01JUElfU0VRX0VMRU1fR1BJT10gPSBtaXBpX2V4ZWNfZ3BpbywKPiAg fTsKPiAgCj4gIC8qCj4gQEAgLTI2NCw3ICsyNjIsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAqc2Vx dWVuY2VfbmFtZShlbnVtIG1pcGlfc2VxIHNlcV9pZCkKPiAgc3RhdGljIHZvaWQgZ2VuZXJpY19l eGVjX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgY29uc3QgdTggKmRhdGEp Cj4gIHsKPiAgCWZuX21pcGlfZWxlbV9leGVjIG1pcGlfZWxlbV9leGVjOwo+IC0JaW50IGluZGV4 Owo+ICAKPiAgCWlmICghZGF0YSkKPiAgCQlyZXR1cm47Cj4gQEAgLTI3NywxNSArMjc0LDE0IEBA IHN0YXRpYyB2b2lkIGdlbmVyaWNfZXhlY19zZXF1ZW5jZShzdHJ1Y3QgaW50ZWxfZHNpICppbnRl bF9kc2ksIGNvbnN0IHU4ICpkYXRhKQo+ICAKPiAgCS8qIHBhcnNlIGVhY2ggYnl0ZSB0aWxsIHdl IHJlYWNoIGVuZCBvZiBzZXF1ZW5jZSBieXRlIC0gMHgwMCAqLwo+ICAJd2hpbGUgKDEpIHsKPiAt CQlpbmRleCA9ICpkYXRhOwo+IC0JCW1pcGlfZWxlbV9leGVjID0gZXhlY19lbGVtW2luZGV4XTsK PiAtCQlpZiAoIW1pcGlfZWxlbV9leGVjKSB7Cj4gLQkJCURSTV9FUlJPUigiVW5zdXBwb3J0ZWQg TUlQSSBlbGVtZW50LCBza2lwcGluZyBzZXF1ZW5jZSBleGVjdXRpb25cbiIpOwo+ICsJCXU4IG9w ZXJhdGlvbl9ieXRlID0gKmRhdGErKzsKPiArCQlpZiAob3BlcmF0aW9uX2J5dGUgPj0gQVJSQVlf U0laRShleGVjX2VsZW0pIHx8Cj4gKwkJICAgICFleGVjX2VsZW1bb3BlcmF0aW9uX2J5dGVdKSB7 Cj4gKwkJCURSTV9FUlJPUigiVW5zdXBwb3J0ZWQgTUlQSSBvcGVyYXRpb24gYnl0ZSAldVxuIiwK Ck1heWJlIERSTV9FUlJPUiBpbiB0aGUgcHJldmlvdXMgcGF0Y2ggdG9vPyBKdXN0IGZvciBvY2Qg Y29uc2lzdGVuY3kuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KCj4gKwkJCQkgIG9wZXJhdGlvbl9ieXRlKTsKPiAgCQkJcmV0dXJuOwo+ICAJCX0K PiAtCj4gLQkJLyogZ290byBlbGVtZW50IHBheWxvYWQgKi8KPiAtCQlkYXRhKys7Cj4gKwkJbWlw aV9lbGVtX2V4ZWMgPSBleGVjX2VsZW1bb3BlcmF0aW9uX2J5dGVdOwo+ICAKPiAgCQkvKiBleGVj dXRlIHRoZSBlbGVtZW50IHNwZWNpZmljIHJvdGluZXMgKi8KPiAgCQlkYXRhID0gbWlwaV9lbGVt X2V4ZWMoaW50ZWxfZHNpLCBkYXRhKTsKPiAtLSAKPiAyLjEuNAo+IAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK