From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 15/15] drm/i915/dsi: reduce tedious repetition Date: Tue, 5 Jan 2016 15:25:14 +0100 Message-ID: <20160105142514.GI8076@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE1DC6E049 for ; Tue, 5 Jan 2016 06:25:17 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id l65so24714606wmf.1 for ; Tue, 05 Jan 2016 06:25:17 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Deepak M , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMjEsIDIwMTUgYXQgMDM6MTE6MDZQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTWFrZSBpdCBhIGJpdCB0aWRpZXIuCgpBbHNvIG1vcmUgc2F2ZS4KCj4gU2lnbmVkLW9m Zi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBE YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jIHwgNjIgKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA0MCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNp X3BhbmVsX3ZidC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5j Cj4gaW5kZXggMWY5YzgwZDIxOTA0Li5mMDExNmE2YzE0Y2QgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gQEAgLTMxNywxOCArMzE3LDMwIEBAIHN0 YXRpYyBjb25zdCBjaGFyICpzZXF1ZW5jZV9uYW1lKGVudW0gbWlwaV9zZXEgc2VxX2lkKQo+ICAJ CXJldHVybiAiKHVua25vd24pIjsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgZ2VuZXJpY19leGVj X3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgY29uc3QgdTggKmRhdGEpCj4g K3N0YXRpYyB2b2lkIGdlbmVyaWNfZXhlY19zZXF1ZW5jZShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5l bCwgZW51bSBtaXBpX3NlcSBzZXFfaWQpCj4gIHsKPiArCXN0cnVjdCB2YnRfcGFuZWwgKnZidF9w YW5lbCA9IHRvX3ZidF9wYW5lbChwYW5lbCk7Cj4gKwlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9k c2kgPSB2YnRfcGFuZWwtPmludGVsX2RzaTsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfZHNpLT5iYXNlLmJhc2UuZGV2KTsKPiArCWNvbnN0IHU4 ICpkYXRhOwo+ICAJZm5fbWlwaV9lbGVtX2V4ZWMgbWlwaV9lbGVtX2V4ZWM7Cj4gIAo+IC0JaWYg KCFkYXRhKQo+ICsJaWYgKFdBUk5fT04oc2VxX2lkID49IEFSUkFZX1NJWkUoZGV2X3ByaXYtPnZi dC5kc2kuc2VxdWVuY2UpKSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JRFJNX0RFQlVHX0RSSVZFUigi U3RhcnRpbmcgTUlQSSBzZXF1ZW5jZSAldSAtICVzXG4iLAo+IC0JCQkgKmRhdGEsIHNlcXVlbmNl X25hbWUoKmRhdGEpKTsKPiArCWRhdGEgPSBkZXZfcHJpdi0+dmJ0LmRzaS5zZXF1ZW5jZVtzZXFf aWRdOwo+ICsJaWYgKCFkYXRhKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiTUlQSSBzZXF1ZW5jZSAl ZCAtICVzIG5vdCBhdmFpbGFibGVcbiIsCj4gKwkJCSAgICAgIHNlcV9pZCwgc2VxdWVuY2VfbmFt ZShzZXFfaWQpKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gIAo+IC0JLyogZ28gdG8gdGhlIGZpcnN0 IGVsZW1lbnQgb2YgdGhlIHNlcXVlbmNlICovCj4gKwlXQVJOX09OKCpkYXRhICE9IHNlcV9pZCk7 Cj4gKwo+ICsJRFJNX0RFQlVHX0tNUygiU3RhcnRpbmcgTUlQSSBzZXF1ZW5jZSAlZCAtICVzXG4i LAo+ICsJCSAgICAgIHNlcV9pZCwgc2VxdWVuY2VfbmFtZShzZXFfaWQpKTsKPiArCj4gKwkvKiBT a2lwIFNlcXVlbmNlIEJ5dGUuICovCj4gIAlkYXRhKys7Cj4gIAo+ICAJLyogU2tpcCBTaXplIG9m IFNlcXVlbmNlLiAqLwo+IEBAIC0zNzAsNTkgKzM4MiwyOSBAQCBzdGF0aWMgdm9pZCBnZW5lcmlj X2V4ZWNfc2VxdWVuY2Uoc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpLCBjb25zdCB1OCAqZGF0 YSkKPiAgCj4gIHN0YXRpYyBpbnQgdmJ0X3BhbmVsX3ByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAq cGFuZWwpCj4gIHsKPiAtCXN0cnVjdCB2YnRfcGFuZWwgKnZidF9wYW5lbCA9IHRvX3ZidF9wYW5l bChwYW5lbCk7Cj4gLQlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSB2YnRfcGFuZWwtPmlu dGVsX2RzaTsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kc2ktPmJhc2UuYmFz ZS5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9w cml2YXRlOwo+IC0JY29uc3QgdTggKnNlcXVlbmNlOwo+IC0KPiAtCXNlcXVlbmNlID0gZGV2X3By aXYtPnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfQVNTRVJUX1JFU0VUXTsKPiAtCWdlbmVyaWNf ZXhlY19zZXF1ZW5jZShpbnRlbF9kc2ksIHNlcXVlbmNlKTsKPiAtCj4gLQlzZXF1ZW5jZSA9IGRl dl9wcml2LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0lOSVRfT1RQXTsKPiAtCWdlbmVyaWNf ZXhlY19zZXF1ZW5jZShpbnRlbF9kc2ksIHNlcXVlbmNlKTsKPiArCWdlbmVyaWNfZXhlY19zZXF1 ZW5jZShwYW5lbCwgTUlQSV9TRVFfQVNTRVJUX1JFU0VUKTsKPiArCWdlbmVyaWNfZXhlY19zZXF1 ZW5jZShwYW5lbCwgTUlQSV9TRVFfSU5JVF9PVFApOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4g IAo+ICBzdGF0aWMgaW50IHZidF9wYW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFu ZWwpCj4gIHsKPiAtCXN0cnVjdCB2YnRfcGFuZWwgKnZidF9wYW5lbCA9IHRvX3ZidF9wYW5lbChw YW5lbCk7Cj4gLQlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSB2YnRfcGFuZWwtPmludGVs X2RzaTsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kc2ktPmJhc2UuYmFzZS5k ZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2 YXRlOwo+IC0JY29uc3QgdTggKnNlcXVlbmNlOwo+IC0KPiAtCXNlcXVlbmNlID0gZGV2X3ByaXYt PnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfREVBU1NFUlRfUkVTRVRdOwo+IC0JZ2VuZXJpY19l eGVjX3NlcXVlbmNlKGludGVsX2RzaSwgc2VxdWVuY2UpOwo+ICsJZ2VuZXJpY19leGVjX3NlcXVl bmNlKHBhbmVsLCBNSVBJX1NFUV9ERUFTU0VSVF9SRVNFVCk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4g IH0KPiAgCj4gIHN0YXRpYyBpbnQgdmJ0X3BhbmVsX2VuYWJsZShzdHJ1Y3QgZHJtX3BhbmVsICpw YW5lbCkKPiAgewo+IC0Jc3RydWN0IHZidF9wYW5lbCAqdmJ0X3BhbmVsID0gdG9fdmJ0X3BhbmVs KHBhbmVsKTsKPiAtCXN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSA9IHZidF9wYW5lbC0+aW50 ZWxfZHNpOwo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RzaS0+YmFzZS5iYXNl LmRldjsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4gLQljb25zdCB1OCAqc2VxdWVuY2U7Cj4gLQo+IC0Jc2VxdWVuY2UgPSBkZXZfcHJp di0+dmJ0LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9ESVNQTEFZX09OXTsKPiAtCWdlbmVyaWNfZXhl Y19zZXF1ZW5jZShpbnRlbF9kc2ksIHNlcXVlbmNlKTsKPiArCWdlbmVyaWNfZXhlY19zZXF1ZW5j ZShwYW5lbCwgTUlQSV9TRVFfRElTUExBWV9PTik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAg Cj4gIHN0YXRpYyBpbnQgdmJ0X3BhbmVsX2Rpc2FibGUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwp Cj4gIHsKPiAtCXN0cnVjdCB2YnRfcGFuZWwgKnZidF9wYW5lbCA9IHRvX3ZidF9wYW5lbChwYW5l bCk7Cj4gLQlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSB2YnRfcGFuZWwtPmludGVsX2Rz aTsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kc2ktPmJhc2UuYmFzZS5kZXY7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRl Owo+IC0JY29uc3QgdTggKnNlcXVlbmNlOwo+IC0KPiAtCXNlcXVlbmNlID0gZGV2X3ByaXYtPnZi dC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfRElTUExBWV9PRkZdOwo+IC0JZ2VuZXJpY19leGVjX3Nl cXVlbmNlKGludGVsX2RzaSwgc2VxdWVuY2UpOwo+ICsJZ2VuZXJpY19leGVjX3NlcXVlbmNlKHBh bmVsLCBNSVBJX1NFUV9ESVNQTEFZX09GRik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAtLSAK PiAyLjEuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK