From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752354AbcAEQL4 (ORCPT ); Tue, 5 Jan 2016 11:11:56 -0500 Received: from imap.thunk.org ([74.207.234.97]:54067 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbcAEQLy (ORCPT ); Tue, 5 Jan 2016 11:11:54 -0500 Date: Tue, 5 Jan 2016 11:11:45 -0500 From: "Theodore Ts'o" To: "Austin S. Hemmelgarn" , G@thunk.org Cc: One Thousand Gnomes , Greg KH , Pierre Paul MINGOT , jslaby@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add possibility to set /dev/tty number Message-ID: <20160105161145.GA7138@thunk.org> Mail-Followup-To: Theodore Ts'o , "Austin S. Hemmelgarn" , G@thunk.org, One Thousand Gnomes , Greg KH , Pierre Paul MINGOT , jslaby@suse.cz, linux-kernel@vger.kernel.org References: <20160104154305.GA24533@kroah.com> <568AA47D.6010604@gmail.com> <20160104171121.GA25961@kroah.com> <568ABCBD.3070909@gmail.com> <20160104225544.158dc847@lxorguk.ukuu.org.uk> <568BC244.5040207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568BC244.5040207@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 08:16:52AM -0500, Austin S. Hemmelgarn wrote: > >We don't do regressions. > Requiring only a recompilation isn't a regression, especially when it works > fine without being recompiled, and I have yet to actually see anything that > changing the number of VT's would break other than ConsoleKit > (systemd-logind might also need a rebuild, but I'm not sure about that, and > don't have a system I could test it on). Sorry, breaking a compiled binary is a regression. People have outlined more clever ways of trying to accomplish your goal (saving memory) without breaking other people. I suggest you give that a try instead of just trying to defend your existing patch. - Ted