From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 4/4] vmxnet3: announce device offload capability Date: Tue, 5 Jan 2016 16:52:05 -0800 Message-ID: <20160105165205.1945e308@xeon-e3> References: <1452039178-15635-1-git-send-email-yongwang@vmware.com> <1452039178-15635-5-git-send-email-yongwang@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Yong Wang Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 75830941C for ; Wed, 6 Jan 2016 01:51:58 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id 78so231625915pfw.2 for ; Tue, 05 Jan 2016 16:51:58 -0800 (PST) In-Reply-To: <1452039178-15635-5-git-send-email-yongwang@vmware.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 5 Jan 2016 16:12:58 -0800 Yong Wang wrote: > > /* return 0 means link status changed, -1 means not changed */ > @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on) > else > VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid); > > - /* don't change active filter if in promiscious mode */ > + /* don't change active filter if in promiscuous mode */ Maybe send a first patch in series with these message and comment cleanups? Makes the review easier, and aides bisection.