From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id ACCD1E00BA4; Tue, 5 Jan 2016 10:52:30 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.115 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 66688E00AEB for ; Tue, 5 Jan 2016 10:52:26 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 05 Jan 2016 10:52:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,525,1444719600"; d="scan'208";a="875129210" Received: from linux.intel.com ([10.23.219.25]) by fmsmga001.fm.intel.com with ESMTP; 05 Jan 2016 10:52:27 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id A5DFC6A4004; Tue, 5 Jan 2016 11:40:23 -0800 (PST) Date: Tue, 5 Jan 2016 18:55:56 +0200 From: Ed Bartosh To: "Barros Pena, Belen" Message-ID: <20160105165556.GA8006@linux.intel.com> References: MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "toaster@yoctoproject.org" Subject: Re: [PATCH 0/8] Support of PRIVIDES X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 18:52:30 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Belen, Thank you for review! I've fixed the issues you've found and updated my branch ed/toaster/provides-6169 Regards, Ed On Tue, Jan 05, 2016 at 12:19:08PM +0000, Barros Pena, Belen wrote: > > > On 29/12/2015 11:56, "toaster-bounces@yoctoproject.org on behalf of Ed > Bartosh" ed.bartosh@linux.intel.com> wrote: > > >Hi, > > > >This patchset adds support of PROVIDES to Toaster backend and frontend. > >Please looks at https://bugzilla.yoctoproject.org/show_bug.cgi?id=6169 to > >see more details. > > > >The following changes since commit > >f74e9383daaba1bc8eb761579f01fadc48771f4a: > > > > toaster-manual: describe the way to start Toaster (2015-12-29 12:53:04 > >+0200) > > > >are available in the git repository at: > > > > git://git.yoctoproject.org/poky-contrib ed/toaster/provides-6169 > > > >http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/provid > >es-6169 > > This looks good to me. Just a couple of small presentation issues: > > * In the 'recipe details' tab, the help text for the 'PROVIDES' entry > should say > > A list of aliases by which a particular recipe can be known. The > additional aliases are synonyms for the recipe and can be useful > satisfying dependencies of other recipes during the build > > Right now it says > > List of names that this recipe privides > > > * In the dependencies tabs, only the recipe name should be inside the > anchor tag. Right now, the 'satisfied via ...' it's also inside the anchor > tag, and that creates an uncomfortable effect when you hover in order to > click the recipe name. > > * Also in the dependencies tabs, the question mark icon should only show > in the table when you hover over the cell (we do this across all tables > and keeps the tables a bit cleaner). You just need to apply the hover-help > class to the tag > > That's all. Thanks! > > Belén > > > > >Ed Bartosh (8): > > taskdata: refactor get_providermap > > cooker: add providermap to dep_tree > > buildinfohelper: use providermap > > toaster: add Provider model > > buildinfohelper: add porvides info to the db > > toaster: show list of provides for the recipe > > toaster: show 'satisfied via' text for build deps > > toaster: show 'satisfied via' text for reverse deps > > > > bitbake/lib/bb/cooker.py | 7 +++++ > > bitbake/lib/bb/runqueue.py | 2 +- > > bitbake/lib/bb/taskdata.py | 17 +++++------- > > bitbake/lib/bb/ui/buildinfohelper.py | 31 > >+++++++++++++++------- > > .../orm/migrations/0002_auto_20151223_1528.py | 27 > >+++++++++++++++++++ > > bitbake/lib/toaster/orm/models.py | 5 ++++ > > .../lib/toaster/toastergui/templates/recipe.html | 25 +++++++++++++++-- > > 7 files changed, 92 insertions(+), 22 deletions(-) > > create mode 100644 > >bitbake/lib/toaster/orm/migrations/0002_auto_20151223_1528.py > > > >-- > >Regards, > >Ed > > > >-- > >_______________________________________________ > >toaster mailing list > >toaster@yoctoproject.org > >https://lists.yoctoproject.org/listinfo/toaster > -- -- Regards, Ed