All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] python-rpi-gpio: new package
Date: Tue, 5 Jan 2016 17:16:31 +0100	[thread overview]
Message-ID: <20160105171631.7c65a813@free-electrons.com> (raw)
In-Reply-To: <1452008648-10885-1-git-send-email-haylocki@yahoo.co.uk>

Ian,

Thanks for your patch!

On Tue,  5 Jan 2016 15:44:08 +0000, Ian Haylock wrote:

> diff --git a/package/python-rpi-gpio/Config.in b/package/python-rpi-gpio/Config.in
> new file mode 100755
> index 0000000..908ab45
> --- /dev/null
> +++ b/package/python-rpi-gpio/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_RPI_GPIO
> +	bool "python-rpi-gpio"
> +	depends on BR2_arm
> +	  help

Indentation of "help" should be one tab, like "bool" and "depends on".

> +	  A Python module to control the GPIO on a Raspberry Pi.
> +
> +	  http://sourceforge.net/p/raspberry-gpio-python
> \ No newline at end of file

You should end the file with a newline.

> diff --git a/package/python-rpi-gpio/python-rpi-gpio.hash b/package/python-rpi-gpio/python-rpi-gpio.hash
> new file mode 100755
> index 0000000..46c4e5b
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.hash
> @@ -0,0 +1,3 @@
> +# md5sum from http://sourceforge.net/projects/raspberry-gpio-python/files/, sha256 calculated locally
> +md5	254d0443a436eb241367c487274e7197	RPi.GPIO-0.6.1.tar.gz
> +sha256	54e5fb06d9ea1a1389a497fb5a06dfa950c86303b0f4ba89b68c55999d1df064	RPi.GPIO-0.6.1.tar.gz
> \ No newline at end of file

Ditto.

> diff --git a/package/python-rpi-gpio/python-rpi-gpio.mk b/package/python-rpi-gpio/python-rpi-gpio.mk
> new file mode 100755
> index 0000000..aa086dc
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-rpi-gpio
> +#
> +################################################################################
> +
> +PYTHON_RPI_GPIO_VERSION = 0.6.1
> +PYTHON_RPI_GPIO_SOURCE = RPi.GPIO-$(PYTHON_RPI_GPIO_VERSION).tar.gz
> +PYTHON_RPI_GPIO_SITE = http://sourceforge.net/projects/raspberry-gpio-python/files
> +PYTHON_RPI_GPIO_LICENSE = MIT
> +PYTHON_RPI_GPIO_LICENSE_FILES = LICENSE.txt
> +PYTHON_RPI_GPIO_SETUP_TYPE = distutils
> +
> +$(eval $(python-package))
> \ No newline at end of file

Ditto.

Other than that, looks good to me.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-01-05 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 15:44 [Buildroot] [PATCH] python-rpi-gpio: new package Ian Haylock
2016-01-05 15:47 ` Yegor Yefremov
2016-01-05 16:16 ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-01-09  9:24 Ian Haylock
2016-01-09  9:28 ` Yegor Yefremov
2016-02-23 23:10 ` Thomas Petazzoni
2016-01-05 10:40 Ian Haylock
2016-01-05 10:46 ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105171631.7c65a813@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.