From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671AbcAEVFM (ORCPT ); Tue, 5 Jan 2016 16:05:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57417 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbcAEVFG (ORCPT ); Tue, 5 Jan 2016 16:05:06 -0500 Date: Tue, 5 Jan 2016 22:05:01 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, stat: Force C numeric locale for CSV mode Message-ID: <20160105210501.GA23394@krava.local> References: <1452021465-17831-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452021465-17831-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 11:17:45AM -0800, Andi Kleen wrote: > From: Andi Kleen > > Some locales print floating point numbers with a comma instead of a dot. > This causes problems with CSV mode because it causes extra false CSV > fields. Force the numeric locale to be always C in CSV mode. > > Before: > > $ LC_ALL=pl_PL.utf8 perf stat -x, true > 0,399472,,task-clock,399472,100,00 <---- extra bogus field > ... > > After: > $ LC_ALL=pl_PL.utf8 ./obj-perf/perf stat -x, true > 0.338422,,task-clock,338422,100.00 > > Originally reported in https://github.com/andikleen/pmu-tools/issues/43 > > Signed-off-by: Andi Kleen Acked-by: Jiri Olsa thanks, jirka