From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290AbcAEV2n (ORCPT ); Tue, 5 Jan 2016 16:28:43 -0500 Received: from one.firstfloor.org ([193.170.194.197]:44348 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbcAEV2l (ORCPT ); Tue, 5 Jan 2016 16:28:41 -0500 Date: Tue, 5 Jan 2016 22:28:39 +0100 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Jiri Olsa , jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, stat: Force C numeric locale for CSV mode Message-ID: <20160105212839.GL15533@two.firstfloor.org> References: <1452021465-17831-1-git-send-email-andi@firstfloor.org> <20160105210501.GA23394@krava.local> <20160105211757.GB25916@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160105211757.GB25916@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 06:17:57PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 05, 2016 at 10:05:01PM +0100, Jiri Olsa escreveu: > > On Tue, Jan 05, 2016 at 11:17:45AM -0800, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > Some locales print floating point numbers with a comma instead of a dot. > > > This causes problems with CSV mode because it causes extra false CSV > > > fields. Force the numeric locale to be always C in CSV mode. > > > > > > Before: > > > > > > $ LC_ALL=pl_PL.utf8 perf stat -x, true > > > 0,399472,,task-clock,399472,100,00 <---- extra bogus field > > > ... > > > > > > After: > > > $ LC_ALL=pl_PL.utf8 ./obj-perf/perf stat -x, true > > > 0.338422,,task-clock,338422,100.00 > > > > > > Originally reported in https://github.com/andikleen/pmu-tools/issues/43 > > > > > > Signed-off-by: Andi Kleen > > > > Acked-by: Jiri Olsa > > I wonder what is that other tools do when stumbling on this, i.e. > some other tool output that produces values that have the CSV character > in it... Proper CSV supports escaping the separator by putting the whole field into quotes. Unfortunately perf stat doesn't output proper CSV, the event fields with commas are not quoted. I usually work around it by using -x\; instead But the , problem should be still fixed. > > Completely disabling the configured locale seems too harsh to me, aren't > people used to changing the csv char via some option like we have in > 'perf stat': > > -x, --field-separator > > when changing the locale from the default 'C' one? Hey, you even used it > above, but you chose a CSV char that is used in this locale, oops ;-) It's just for numbers (LC_NUMERIC), everything else is still localized. -Andi