From: Javi Merino <javi.merino@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Punit Agrawal <punit.agrawal@arm.com>,
Daniel Kurtz <djkurtz@chromium.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power
Date: Wed, 6 Jan 2016 10:07:13 +0000 [thread overview]
Message-ID: <20160106100712.GA2790@e104805> (raw)
In-Reply-To: <1452070428-2567-1-git-send-email-leo.yan@linaro.org>
On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote:
> k_po/k_pu are two proportional term constants and essentially they have
> fixed ratio compared with sustainable power. In current implementation,
> k_po and k_pu are absolute value after calculation and cannot represent
> the ratio relationship with sustainable power; as a result, when change
> sustainable power we cannot smoothly change proportional term constant.
In v2 Daniel said that the use case was made up. Can you elaborate on
why we need this?
> So this patch series introduces k_po_ratio and k_pu_ratio, which
> represent the ratio value compared against sustainable power. Also add
> sys file system nodes for them for easily update them from userspace and
> update a bit in documentation.
Actually, it makes it harder to update from userspace. Now userspace
can't set a k_po/k_pu any more, and it's forced to set them as ratios
of sustainable power. I'd rather not do this unless there is a good
reason for it.
Cheers,
Javi
next prev parent reply other threads:[~2016-01-06 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 8:53 [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power Leo Yan
2016-01-06 8:53 ` [PATCH v3 1/4] thermal: power_allocator: rework proportional parameter Leo Yan
2016-01-06 8:53 ` [PATCH v3 2/4] thermal: power_allocator: change k_pu_ratio/k_po_ratio as percentage Leo Yan
2016-01-06 8:53 ` [PATCH v3 3/4] thermal: add sys node for k_pu_ratio/k_po_ratio Leo Yan
2016-01-06 8:53 ` [PATCH v3 4/4] thermal: power_allocator: document k_pu_ratio/k_po_ratio Leo Yan
2016-01-06 10:07 ` Javi Merino [this message]
2016-01-06 11:17 ` [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power Leo Yan
2016-01-06 11:21 ` Daniel Thompson
2016-01-06 15:05 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106100712.GA2790@e104805 \
--to=javi.merino@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=djkurtz@chromium.org \
--cc=edubezval@gmail.com \
--cc=leo.yan@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.