From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkoo-00023r-0r for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:55:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGkol-0001EZ-9m for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:55:49 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:38122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkol-0001EN-0l for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:55:47 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Jan 2016 09:55:45 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8E7952190056 for ; Wed, 6 Jan 2016 09:55:32 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u069thLL61276192 for ; Wed, 6 Jan 2016 09:55:43 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u069tgtp027699 for ; Wed, 6 Jan 2016 02:55:42 -0700 Date: Wed, 6 Jan 2016 10:55:39 +0100 From: Greg Kurz Message-ID: <20160106105539.4bee4e9f@bahia.local> In-Reply-To: <1452015002-28493-3-git-send-email-clg@fr.ibm.com> References: <1452015002-28493-3-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: Corey Minyard , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Tue, 5 Jan 2016 18:29:56 +0100 C=C3=A9dric Le Goater wrote: > Signed-off-by: C=C3=A9dric Le Goater > --- Acked-by: Greg Kurz Just some minor comments on the form below. > hw/ipmi/ipmi_bmc_sim.c | 51 ++++++++++++++++++++++++++++++++++++++++++++= ++++-- > 1 file changed, 49 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 559e1398d669..061db8437479 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -37,13 +37,15 @@ > #define IPMI_CMD_CHASSIS_CONTROL 0x02 >=20 > #define IPMI_NETFN_SENSOR_EVENT 0x04 > -#define IPMI_NETFN_SENSOR_EVENT_MAXCMD 0x2e > +#define IPMI_NETFN_SENSOR_EVENT_MAXCMD 0x30 >=20 Maybe IPMI_NETFN_SENSOR_EVENT_MAXCMD should be defined... > #define IPMI_CMD_SET_SENSOR_EVT_ENABLE 0x28 > #define IPMI_CMD_GET_SENSOR_EVT_ENABLE 0x29 > #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a > #define IPMI_CMD_GET_SENSOR_EVT_STATUS 0x2b > #define IPMI_CMD_GET_SENSOR_READING 0x2d > +#define IPMI_CMD_SET_SENSOR_TYPE 0x2e > +#define IPMI_CMD_GET_SENSOR_TYPE 0x2f >=20 ... here ? > /* #define IPMI_NETFN_APP 0x06 In ipmi.h */ > #define IPMI_NETFN_APP_MAXCMD 0x36 > @@ -1576,6 +1578,49 @@ static void get_sensor_reading(IPMIBmcSim *ibs, > return; > } >=20 > +static void set_sensor_type(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMISensor *sens; > + > + > + IPMI_CHECK_CMD_LEN(5); > + if ((cmd[2] > MAX_SENSORS) || Parenthesis not needed here since > has precedence over || > + !IPMI_SENSOR_GET_PRESENT(ibs->sensors + cmd[2])) { Indentation ? > + rsp[2] =3D IPMI_CC_REQ_ENTRY_NOT_PRESENT; > + goto out; > + } > + sens =3D ibs->sensors + cmd[2]; > + sens->sensor_type =3D cmd[3]; > + sens->evt_reading_type_code =3D cmd[4] & 0x7f; So evt_reading_type_code is 7bit ? Maybe worth to introduce a IPMI_SENSOR_TYPE_MASK define. > + > + out: > + return; > +} > + > +static void get_sensor_type(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMISensor *sens; > + > + > + IPMI_CHECK_CMD_LEN(3); > + if ((cmd[2] > MAX_SENSORS) || > + !IPMI_SENSOR_GET_PRESENT(ibs->sensors + cmd[2])) { Parenthesis and indentation ? > + rsp[2] =3D IPMI_CC_REQ_ENTRY_NOT_PRESENT; > + goto out; > + } > + sens =3D ibs->sensors + cmd[2]; > + IPMI_ADD_RSP_DATA(sens->sensor_type); > + IPMI_ADD_RSP_DATA(sens->evt_reading_type_code); > + out: > + return; > +} > + > static const IPMICmdHandler chassis_cmds[IPMI_NETFN_CHASSIS_MAXCMD] =3D { > [IPMI_CMD_GET_CHASSIS_CAPABILITIES] =3D chassis_capabilities, > [IPMI_CMD_GET_CHASSIS_STATUS] =3D chassis_status, > @@ -1592,7 +1637,9 @@ sensor_event_cmds[IPMI_NETFN_SENSOR_EVENT_MAXCMD] = =3D { > [IPMI_CMD_GET_SENSOR_EVT_ENABLE] =3D get_sensor_evt_enable, > [IPMI_CMD_REARM_SENSOR_EVTS] =3D rearm_sensor_evts, > [IPMI_CMD_GET_SENSOR_EVT_STATUS] =3D get_sensor_evt_status, > - [IPMI_CMD_GET_SENSOR_READING] =3D get_sensor_reading > + [IPMI_CMD_GET_SENSOR_READING] =3D get_sensor_reading, > + [IPMI_CMD_SET_SENSOR_TYPE] =3D set_sensor_type, > + [IPMI_CMD_GET_SENSOR_TYPE] =3D get_sensor_type, > }; > static const IPMINetfn sensor_event_netfn =3D { > .cmd_nums =3D IPMI_NETFN_SENSOR_EVENT_MAXCMD,